A module to watch whats going on in the drupal cache tables. It uses the fancy krumo viewer to show the strings, arrays, object etc. which are stored in the cache tables. The module is extremely useful for developers you want to understand the drupal built in cache mechanism.

http://drupal.org/sandbox/JosefFriedrich/1906348

git.drupal.org:sandbox/JosefFriedrich/1906348.git
git clone --recursive --branch master JosefFriedrich@git.drupal.org:sandbox/JosefFriedrich/1906348.git cache_inspector

Drupal 7 only

My reviews:
http://drupal.org/node/1912532#comment-7060676
http://drupal.org/node/1914740#comment-7060598
http://drupal.org/node/1909588#comment-7060758

Comments

npscode’s picture

npscode commented
Status: Needs review » Needs work

Hi JosefFriedrich,

Looks a good module to understand drupal cache mechanism.

some points that i noticed:

  1. If i select any option from "Select cache table" list. After submitting the form it should remain selected. which is not happening right now.
  2. After submitting, we can use query string instead of $_SESSION['cache_inspector'] to find out the selected option. Because once the session is set i can not see all the cached values. I am bound to select an option from the list.
  3. Found one code formatting issue. check http://ventral.org/pareview/httpgitdrupalorgsandboxjoseffriedrich1906348git.
joseffriedrich’s picture

joseffriedrich commented

Hallo npscode!

Thank you for your review.

I improved, what you suggested in 1. and 3. and commited the changes.

Unfortunately I don't understand what you mean in "2.". Can you please describe the issue more precisely. The $_SESSION variable is e. g. used in node.admin.inc to filter the content types.

joseffriedrich’s picture

joseffriedrich commented
Status: Needs work » Needs review
joseffriedrich’s picture

joseffriedrich commented
Issue summary: View changes

Add review link

joseffriedrich’s picture

joseffriedrich commented
Issue summary: View changes

review link

joseffriedrich’s picture

joseffriedrich commented
Issue tags: +PAreview: review bonus

I was industrious, so i can add the PAReview: review bonus tag ;-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » dave reid
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

manual review:

  • cache_inspector.info: "core" is duplicated.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

joseffriedrich’s picture

joseffriedrich commented

3 reviews more:
http://drupal.org/node/1918036#comment-7080622
http://drupal.org/node/1913916#comment-7080752
http://drupal.org/node/1919516#comment-7080810

joseffriedrich’s picture

joseffriedrich commented
Issue tags: +PAreview: review bonus

I was industrious again, so i can add the review bonus tag again ;-)

joseffriedrich’s picture

joseffriedrich commented

I committed the changes form the manual review of klausi.

jthorson’s picture

jthorson commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, JosefFriedrich!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

add review link