SimplenewsSubscriber::$newsletter_ids not defined [#1914110]

Notice: Undefined property: SimplenewsSubscriber::$newsletter_ids in party_simplenews_subscriptions_edit_form() (line 80 of /home/partyopoly/domains/partyopolydev.commonnonsense.co.uk/public_html/sites/all/modules/modified/party_simplenews/party_simplenews.pages.inc).

Warning: array_merge(): Argument #2 is not an array in array_merge() (line 80 of /home/partyopoly/domains/partyopolydev.commonnonsense.co.uk/public_html/sites/all/modules/modified/party_simplenews/party_simplenews.pages.inc).

Warning: Invalid argument supplied for foreach() in form_type_checkboxes_value() (line 2288 of /home/partyopoly/domains/partyopolydev.commonnonsense.co.uk/public_html/includes/form.inc).

Comment	File	Size	Author
#1	1914110-1-add_newsletter_ids_property_to_SimplenewsSubscriber.patch	524 bytes	andrewbelcher

Comments

Comment #1

andrewbelcher commented 11 February 2013 at 12:39

Title:	Notices and warnings thrown by party_simplenews	» SimplenewsSubscriber::$newsletter_ids not defined
Project:	OpenCRM Kickstart	» Simplenews
Version:		» 7.x-2.x-dev

Status	File	Size
new	1914110-1-add_newsletter_ids_property_to_SimplenewsSubscriber.patch	524 bytes

The problem is SimplenewsSubscriber doesn't define the $newsletter_ids property, it just get's filled out in SimplenewsSubscriberController::attachLoad(). This means that when an entity is created rather than loaded, the property never gets set.

I suppose module developers could always do an isset(), but that seems a bit odd for a property that is vital to the functioning of a subscriber. The attached patch fixes it.