After rating of a content it should be show a Thank you for your rating text snippet.

Issue fork fivestar-1916954

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr’s picture

tr commented
Version: 7.x-2.0-alpha2 » 8.x-1.x-dev
Issue summary: View changes

New features should go into the current version first, then be backported if there is interest from the community.

Arijit Acharya made their first commit to this issue’s fork.

Arijit Acharya opened merge request !21

arijit acharya’s picture

arijit acharya commented

I have added a JQuery function that displays the thank you message after 250ms of user click. I have also added some CSS to that message class for styling the text.

ravi kant’s picture

ravi kant commented
Status: Active » Needs review
sandipta’s picture

sandipta commented

Hi, I have tested the MR and it is working fine.

tr’s picture

tr commented
Status: Needs review » Needs work

If you do it entirely in the Javascript then it can't be translated or customized. Also, it can't be turned off, so this represents a change in functionality for people who already have this module installed.

The text should be in the config settings with an option in the UI to change it, and the markup should be in the templates with a CSS class defined so that it can be styled.

vivek panicker’s picture

vivek panicker commented
Status: Needs work » Needs review
tr’s picture

tr commented
Status: Needs review » Needs work

Tests fail, and the patch introduces more than 30 coding standards errors.