Create configuration schemas for forum module

updating schema as per code style in http://drupal.org/node/1905070#codestyle and verified in config_inspector

Thanks @vijaycs85, updated patch as per the comment.

Reviewing and updated SprintWeekend tag.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+# Schema for the configuration files of the Forum module

This should end in a period.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+# Schema for the configuration files of the Forum module

This should end in a period.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+      type: string

Containers is not a string, but a sequence.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+        hot_threshold:
+          type: integer
+          label: 'Hot topic threshold'

This might be a little picky, but I think this deserves a comment as well. Unless you're some kind of forum.module expert this is very hard to understand, and I doubt many people are...

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+        order:
+          type: integer
+          label: 'Default order'

This (as well as the actual config) should contain a comment referencing _forum_get_topic_order() because this is near impossible to understand without it.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+      type: integer

The vocabulary ID is a string, not an integer. It is currently '0', by default, but it really should be ''.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+      label: 'Forum vocabulary'

I think this should be 'Forum vocabulary ID' for clarity.

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,44 @@
+# Schema for the configuration files of the Forum module

This should end in a period.

Crosspost, didn't mean to unassign.

I think that:

'vocabulary' => 'forums'

Should be 'string' not 'integer'. Am I right?

It's the one and only error I have found.

Thanks to @tstoeckler and @rteijeiro for comments. Corrected labels as per comment.

Containers store taxonomy term ID's, so the type is integer instead of string.

It seems that it's solved:

+++ b/core/modules/forum/config/schema/forum.schema.yml
@@ -0,0 +1,46 @@
+# Schema for the configuration files of the Forum module.

Ending in period.

+    containers:
+      type: sequence
+      label: 'Containers to group related forums'
+      sequence:
+        - type: string
+          label: 'Containers to group related forums'

Now containers is sequence.

+    vocabulary:
+      type: string
+      label: 'Forum vocabulary ID'

Now vocabulary is string and it's label is changed.

But I am not sure if there should be the comments mentioned in http://drupal.org/node/1919176#comment-7155320

I marked it as "needs review" so tstoeckler should review it better than me :)

It seems the last review is for #9, so #10 has not been reviewed yet.

I still think we could use some inline comments here, but since we haven't done that for most of the other schema files I won't be a stickler.

I'm not sure about the taxonomy term ID. It is currently stored as an integer in the DB, but we don't really enforce that in the entity system. I.e. someone could make taxonomy terms use the ConfigStorageController and use machine names for taxonomy terms. So maybe we should use string here. On the other hand the actual data is an integer, so I *think* it is correct to use integer.

I am (tentatively) marking this RTBC, and, thus, relaying this question to the core committers.

Committed to 8.x, thanks! Will push once testbot's caught up a bit.