Closed (won't fix)
Project:
Link
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Feb 2013 at 08:32 UTC
Updated:
14 Nov 2019 at 10:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mu5a5hi commentedSame here.. My links were gone. I checked my views and the field was gone from the selected fields. Reverted and it's back to normal.
Comment #2
jcfiala commentedDid you clear the cache? Generally if you have a problem after doing an update, you should clear the site cache.
Comment #3
mu5a5hi commentedI don't know about Marc, but in my case cache clearing didn't have any effect.
I'm going to try installing on a dev site today and see if i can figure out any more 'variables' to the issue.
Comment #4
Steven Brown commentedSubcribing I'm experiencing this as well.
Comment #5
drakythe commentedI am also getting this issue. I have cleared cache. Nothing seems to solve the issue. I removed the link field from my View and the issue went away.
Comment #6
marcdecaluwe commentedCache clearing doesn't help - i'll take a closer look at what can cause this
Comment #7
mu5a5hi commentedDid the test on dev version of site. Same results. Caches cleared.
reports/deblog page says this:
substr() expects parameter 3 to be long, string given in /var/www/eng.vt.edu/sites/all/modules/link/link.inc on line 111.
Comment #8
marcdecaluwe commentedIf I put the following line in the file link.module
require_once 'link.theme.inc';
the problem is solved.
They dit put some functions in a separate file but forgot to include it.
Comment #9
drakythe commented#7 That seems to be a different error, might require a different thread.
I've gone ahead and renamed the issue to be more specific than a catchall thread.
#8 care to post a patch?
Comment #10
marcdecaluwe commentedOk - I'll post a patch on Monday.
Comment #11
marcdecaluwe commentedPatch for this issue
Comment #12
marcdecaluwe commentedPatch uploaded under comment 11
Comment #13
byronveale commentedTried the 6.x-2.x-dev version, problem seems to be fixed.
Perhaps patch from #11 above was implemented?
See also this issue:
http://drupal.org/node/1924904
Thanks to all involved!
Comment #14
byronveale commentedOne more note: checking another site, it was using the "fixed" dev version of link, but was still getting this php error, and the link fields were not visible. At first, I thought the problem still remained; then I cleared all caches. No more problem...
Comment #15
dr.user commented[deleted]
Comment #16
drakythe commentedPer #13 I am marking this as needs review since it seems to be fixed.
dr.user no need to "bump" topics, maintainers will get to them when they have a chance. Also please try the dev release as it seems to be patched, be sure to run update.php and clear cache to see if your problem is resolved. Also, if you need to subscribe to the topic these days there is a subscribe button in the upper right hand corner of the initial issue post.
Comment #18
jcfiala commentedSo, here's the thing. hook_theme properly has a 'file' attribute for each theme function as is specified in https://api.drupal.org/api/drupal/developer%21hooks%21core.php/function/... - as per the documentation, and from all of my experience, that means that the link.theme.inc should be automatically included when any of these theme functions are called... which is why clearing the cache should fix this. The whole point of having them in a different file is so that theme functions don't have to be included on every pageload even if they're not used. This is the same thing that's used in the node module for the node add page, for goodness sakes!
If the theme layer isn't including files properly on your sites, then there's a bigger problem than just my module.
Comment #19
jcfiala commentedAnd to follow up with that, the theme functions have been in link.theme.inc for over three years now - this isn't a new change.
So.. what would cause this? I don't know.
Comment #20
damienmckennaThank you all for your efforts, but I'm sorry to say that the D6 version is no longer supported.