Node title mismatch when title contains special characters

I have a similar problem but the patch in #1 could not solve it.

i want to map a simplified chinese node to traditional chinese node. after i submit the translation set, it throws "Node title mismatch: Please check your selection".

so i looked into the i18n_node.pages.inc and find the problem is on the validation.

function i18n_node_autocomplete2nid($name, $field = NULL, $type, $language) {
  if (!empty($name)) {
    preg_match('/^(?:\s*|(.*) )?\[\s*nid\s*:\s*(\d+)\s*\]$/', $name, $matches);
    if (!empty($matches)) {
      // Explicit [nid:n].
      list(, $title, $nid) = $matches;
      if (!empty($title) && ($node = node_load($nid)) && $title != $node->title) {
        if ($field) {
          form_set_error($field, t('Node title mismatch. Please check your selection.'));
        }
        $nid = NULL;
      }

i write the $title and $node->title to watch dog. the string is exactly the same. and i check them with mb_detect_encoding and both of them are utf8.

any idea?

I finally find a solution to solve the problem. that is wrap the strings by trim() before comparison.

  //if (!empty($title) && ($node = node_load($nid)) && $title != $node->title) {
  if (!empty($title) && ($node = node_load($nid)) && trim($title) != trim($node->title)) {

I can confirm that the issue (in my case, having apostrophes in the title) is resolved using the patch RaF provided in #1. It's hard to determine if this is the best workaround or not as the check_plain may be needed in some instances. In any case, testing this some more and rolling it into the project would be worth while. Changing status to "needs review" and re-attaching .patch file to get this process started.

Thanks RaF

Right, we don't need the check_plain() there that causes a double 'check_plain' when the form element attributes are processed.

Thanks.

@ykyuen,
If this doesn't fix your issue, which may be a different one, please create a new issue.