Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As a post 3.0 feature, it would be great to introduce a responsive admin toolbar, since the core toolbar looks pretty poor on phone-sized devices.
One candidate would be http://drupal.org/project/navbar, though it needs some maintainership to bring it past alpha.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | 1920354-navbar-drupal-make-17.patch | 3.58 KB | japerry |
| #15 | add-navbar-module-1920354-15.patch | 3.47 KB | Devin Carlson |
| #13 | desktop_horizontal.png | 292.66 KB | Devin Carlson |
| #13 | mobile_vertical.png | 47.08 KB | Devin Carlson |
| #8 | 1920354-tinynav-commons.patch | 2.04 KB | ezra-g |
Comments
Comment #1
ezra-g CreditAttribution: ezra-g commentedLet's also include a responsive administrative theme.
Comment #2
ezra-g CreditAttribution: ezra-g commentedI propose we use the included AT Admin theme.
Comment #3
ezra-g CreditAttribution: ezra-g commentedAT Admin is now the administrative theme.
http://drupalcode.org/project/commons.git/commit/a53ad7d
http://drupalcode.org/project/commons.git/commit/639c9d5
Comment #4
ezra-g CreditAttribution: ezra-g commentedjessebeach suggested http://drupal.org/project/tinynav with the following variable config:
tinynav_active_class: "active-trail"
tinynav_css_selector: "#zone-menu .region-menu ul.menu, #toolbar-menu"
tinynav_header: 0
tinynav_media_query: "all and (max-width:780px)"
Bumping this to major given the importance of the mobile experience for folks evaluating Commons as admins.
Comment #5
ezra-g CreditAttribution: ezra-g commentedComment #6
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedhow about http://drupal.org/project/navbar
Comment #7
rickvug CreditAttribution: rickvug commentedConceptually I like it. A few comments for improvements:
- We should add a media query to hide the Acquia subscription details at mobile widths.
- Theming is required to match the look and feel (white is out of place)
- What about removing Shortcuts from the list of modules enabled on install? I've never seen anyone actually use the functionality. It just clutters the toolbar as well as your user account with the shortcut sets tab. This is especially problematic at small screen sizes.
- Drop the content in brackets from the links. If the selector was narrower the home button and account links wouldn't wrap when viewing from a mobile device.
Comment #8
ezra-g CreditAttribution: ezra-g commentedThanks for the feedback, @rickvug!
@SocialNicheGuru, please see the OP: NavBar is not yet production ready, but would make a great post Commons 3.0 addition with some work.
I have this in a state that I believe is RTBC in the 1920354-tinynav branch of Commons. Attached is a patch showing the proposed changes, and a screenshot of what TinyNav looks like on the admin/people page with AT_Admin theme enabled.
Comment #9
ezra-g CreditAttribution: ezra-g commentedUpdating with the remaining action item. Would be great to get a comment from the Spark team on any related issues here.
Comment #10
webchick#1860434: Refactor the Toolbar JavaScript to use Backbone; fix several poorly functioning behaviors and #1847084: Measure/track displacing elements better + provide change events for them (fix overlay + toolbar) (just recently committed) are the two I'm aware of. jbeach would have the whole down-low. :)
Comment #11
jessebeach CreditAttribution: jessebeach commented1847084 was committed on March 29.
Comment #12
ezra-g CreditAttribution: ezra-g commentedSounds like Navbar could be ready in time to be incorporated into the Commons 3.3. release. Marking postponed and tagging for our 3.3 radar.
Comment #13
Devin Carlson CreditAttribution: Devin Carlson commentedI've compiled some information on the current state of the navbar module:
Dependencies
Modules
Libraries
Issues
The navbar module currently works well (as demonstrated in the screenshots below) but has a few small issues that may require testing/patching:
Comment #14
Devin Carlson CreditAttribution: Devin Carlson commentedThe issues mentioned in #10 have been fixed and were backported from D8 to navbar in 7.x-1.0-alpha9 (release notes) so I'm moving this back to "active".
Comment #15
Devin Carlson CreditAttribution: Devin Carlson commentedA patch to add the Navbar and Breakpoints module, add the backbone and underscore libraries and provide an upgrade path from Toolbar to Navbar.
Comment #16
japerryGreat work, I'll be really happy to see something better than the crappy admin toolbar we have now. :-)
Two things however:
1) underscore fails to package. the tar.gz is not listed in the whitelist. It should be:
libraries[underscore][download][url] = "https://github.com/documentcloud/underscore/archive/1.4.4.zip"
2) it looks like there is an ordering issue between underscore and backbone.js. Its causing a JS error to be thrown: Timestamp: 6/6/13 9:41:50 AM Error: TypeError: this.$el.off is not a function Source File: http://commons3/profiles/commons/libraries/backbone/backbone-min.js?v=1.0.0 Line: 1
It looks like its a result of backbone.js being called before underscore.
Comment #17
japerryThis patch uses the most recent version of navbar, which appears to fix the issue found in issue 16a and b.
It should be good to go, based on the discussion with Ezra and Jesse
Comment #18
Devin Carlson CreditAttribution: Devin Carlson commentedThe patch in #17 applied cleanly and uses the most recent version of navbar which fixed the issues with -alpha10. I also tested the upgrade path and didn't run into any issues with migrating toolbar permissions to navbar.
Comment #19
japerryFixed!
http://drupalcode.org/project/commons.git/commit/c372eb1