About:

For Drupal 7 only (Drupal 8 in progress, no backport plans)

This theme is not a 'full' Drupal theme, but rather a very lightweight theme designed to meet a somewhat specific use-case scenario.

The theme covers three 'pages'.

  • user/login
  • user/register
  • user/password

It is designed to work with a number of contrib modules and is somewhat useless without these modules. The module was designed to provide, along with the contrib modules it 'depends' on, a simple, clean login entry page for a Drupal site or a Drupal/CiviCRM site.

Links:

Project Page: https://drupal.org/sandbox/mikeyllb/1923846
GIT Clone: git clone --recursive git@git.drupal.org:sandbox/mikeyllb/1923846.git

PAReview Output:

http://ventral.org/pareview/httpgitdrupalorgsandboxmikeyllb1923846git

(No issues on 24/02/2013)

Reviews of other projects:

https://drupal.org/node/1891548#comment-7096928
https://drupal.org/node/1921488#comment-7104080
https://drupal.org/node/1777996#comment-7104644

CommentFileSizeAuthor
#6 Portal_theme_login.png406.02 KBnsuit
#6 Portal_theme_page_view.png341.37 KBnsuit
#1 Screen Shot 2013-02-21 at 12.40.50.png1.11 MBHomotechsual
#1 Screen Shot 2013-02-21 at 12.40.50.png1.11 MBHomotechsual

Comments

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Corrected IMG

Homotechsual’s picture

Homotechsual commented
StatusFileSize
new Screen Shot 2013-02-21 at 12.40.50.png1.11 MB
new Screen Shot 2013-02-21 at 12.40.50.png1.11 MB

Attaching image - Only local images are allowed. tag not working despite img src being https://drupal.org/files/project-images/Screen%20Shot%202013-02-21%20at%...

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Removed IMG - not working.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Correction

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Adding Project Rewiew

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Correcting Link

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Corrected heading

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Added new review.

Homotechsual’s picture

Homotechsual commented
Issue summary: View changes

Added Ventral link

Homotechsual’s picture

Homotechsual commented
Issue tags: +PAreview: review bonus

Adding tag: PAReview: review bonus

nsuit’s picture

nsuit commented

Hi MJCO,

The header and footer regions are overlapping with the content area and makes the tab in the content area unclickable. At least that is what I was experiencing when I enabled the theme. I work on Safari, Firefox, Chrome on OSX 10.8. There is a lot of space (maybe too much) between each of the items as well as username and password input fields on the login screen.

Homotechsual’s picture

Homotechsual commented

I'm also using OSX 10.8 - not seeing the same issues. Would you be able to post a screenshot?

As per the description this theme is ONLY for user/login user/register and user/password. It will not function correctly for other pages.

nsuit’s picture

nsuit commented
StatusFileSize
new Portal_theme_page_view.png341.37 KB
new Portal_theme_login.png406.02 KB
Homotechsual’s picture

Homotechsual commented

Yeah, as I figured. You aren't on user/login user/register or user/password. Therefore this theme is not expected to work.

The theme is for a very narrow use case along with a series of modules as listed on the project page and in the readme. It's for themeing ONLY the login/register/password pages.

nsuit’s picture

nsuit commented

Ok, I see. Maybe it needs to be pointed out that this doesn't work with the default login screen.

Homotechsual’s picture

Homotechsual commented

It's covered in readme.txt and on the project page currently that the theme only covers user/login, user/password and user/register.

I'm open to clarifying however I'm not sure where else this should be covered.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » sreynen
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

manual review:

  • page.tpl.php: the footer stuff is all hard coded examples? Shouldn't that be theme settings?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to sreynen as he might have time to take a final look at this.

Homotechsual’s picture

Homotechsual commented

Hi Klausi - thanks for the review.

The client name, client url, designer name, designer url in the footer are now controlled as theme settings.

The attribution block/logos on the left are now controlled by an on/off switch in addition to an on/off switch for the civicrm logo (separately to the overall attribution switch).

Thanks very much for the suggestion.

sreynen’s picture

sreynen commented
Assigned: sreynen » Unassigned
Status: Reviewed & tested by the community » Fixed

Hi MJCO,

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added project review.