Closed (fixed)
Project:
Fivestar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2013 at 01:21 UTC
Updated:
16 Mar 2014 at 17:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hass commentedThe title has also not migrated and has been set to
field_voteComment #2
whiteph commentedMoved the priority down. Using the definitions in Priority levels of issues, where it says Bugs that affect one piece of functionality are normal priority. An example would be the category filter not working on the database log screen. This is a self-contained bug and does not impact the overall functionality of the software.
This issue is a year old - is there still any interest in it being fixed?
Comment #3
hass commentedWhy not? It's still broken and a beta means the upgrade path is working, but it is broken. Data loss has a higher prio than normal.
Comment #4
whiteph commentedFair enough. I was thinking that data loss in normal use would have a higher priority, not convinced about data loss during a one-off migration. I'm happy to bump it back up again, especially with your quick response. It might take a while to fix though, as I don't even have a D6 test system - I've come into the Drupal world at the tail end of D7.
Comment #5
whiteph commentedPatch attached. I can't test, as I don't have a D6 test system. Feedback would be appreciated.
I'm planning to commit it later today anyway, as there's very little downside: D7 users won't be affected by it; and D6 users migrating without the patch will have this issue and then look for a solution - but it will already be too late. The patch removes three lines where settings are updated from bad values; the title is added to the settings array; and the widget array is set. None of these changes are likely to cause new problems, and have a high probability of fixing the issues.
Comment #6
whiteph commented