Hi.

I'm translating rc3 to spanish and "Select other style to preview" string is missing.
I have found it in 7.x-1.0-rc1 version and it's already translated and approved.
So I suppose the question it to "assign" it to rc3. Could you do it?
I have asked for it to localize manager but it seems to be your question.

Many thanks!

CommentFileSizeAuthor
#2 1924546-2-preview-string.patch1014 bytesianthomas_uk
ScreenShot011.jpg35.43 KBjosean

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Version: 7.x-1.0-rc3 » 7.x-1.x-dev
Issue summary: View changes

The problem is this line
'#title' => $imagecrop->getInCroppingMode() ? t('Select other style to '. $action) : t('Select style to preview'),

$action shouldn't be passed to t() in this way and should be translatable itself.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Active » Needs review
StatusFileSize
new 1924546-2-preview-string.patch1014 bytes

Here is a patch that converts the untranslatable 'Select other style to $action' to either 'Select style to crop' or 'Select other style to preview'. The other is added because you can't go back to preview by re-selected the same style.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Needs review » Fixed

Committed and pushed to 7.x-1.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.