Rename various CSS files to match new file naming convention

Testing with that:
- Moved the block.admin.css file to a new "css" folder created in the module.
- Changed the name from block.admin.css to block.admin.skin.css.

Changing status to "needs review" to test patch.

Please adjust your git configuration to use renames=copies. See Configuring Git for details.

Thanks aspilicious.

sun: ok, I'll check it and then I will upload the rest ofe the patch.

Changes done in all modules mentioned in the issue:
- Rename MODULE.css or MODULE.admin.css to MODULE.admin.skin.css
- Moved all in the new module css folder.
- Moved -rtl.css files to css folder too, and renamed as MODULE.admin.skin-rtl.css (based on language.module function language_css_alter). Anyway, left previous name fors entity_reference-rtl.admin.css to entity_reference-rtf.admin.skin.css because I'm not sure how it works.

I just want to point out that module.admin.css should remain, containing structural styles only (layout, component styles required for functionality). The styles that are moved to module.admin.skin.css should be those related to appearance, like border, background, border-radius, etc.

Updating tags

OK, first thanks for help to novices.
Here I add separate block and color patches. What I've done to them:
- block

• created css folder and move inside the css files
• separated admin.css and admin.skin.css
• changed reference path to css in block.admin.inc and lib/Drupal/block/BlockListController.php

- color

• created css folder and move inside the css files
• changed reference path to css in color.module

I'll put all together into a single patch when all of them are correct.
- dblog

• created css folder and move inside the css files
• changed reference to css in dblog.module

- entity_refrence

• changed name from entity_reference-rtl.admin.css to entity_reference.admin-rtl.css

- field_ui

• created css folder and move inside the css files
• changed reference to css in field_ui.module

I think you could post intermediary patches with the "-do-not-test" suffix. The 5 from above will generate 5 hours of testbot working time which could be spent on dozens of other patches..

That being said, would you mind if I cancel their testing so other sprinters can have a chance at seeing the result of their patches today? :)

Sure, I did not know that!

Moved the css files of the listed modules to the new css/ directory, and changed the refrence to it in the module files.

I've done some other changes that would be great that someone more confortable with D8-css-structures could review. Those changes are:
block
- separated block.admin.css and block.admin.skin.css
- changed reference to css in block.admin.inc and lib/Drupal/block/BlockListController.php
entity_refrence
- Changed name from entity_reference-rtl.admin.css to entity_reference.admin-rtl.css (not sure if it's correct)
filter
- separated admin.css and admin.skin.css
help
- rename help.css/help-rtl.css to help.admin.css/help.admin-rtl.css (not sure if it's correct)
help
- rename update.css/update-rtl.css to help.admin.css/help.admin-rtl.css (not sure if it's correct)

Attaching the whole patch in a zip so it can be tested but not requires testbot untill I'm sure the changes are fine.

Hi ckrina, the patch returns some errors when applied:

error: core/modules/locale/locale-rtl.css: No such file or directory
error: patch failed: core/modules/menu/menu.admin.inc:71
error: core/modules/menu/menu.admin.inc: patch does not apply

I'm reviewing the code.

The patch doesn't create the css files for some modules. It only deletes the css files.

I guess it's needed to recreate the patch again.

I have created the patch from scratch. Hope now it's right.

Hi rteijeiro, thanks to take a look to that. I wasn't able to follow it the past days.
I've been testing your patch and I think there are some problems:
- The old CSS files outside the css folder aren't deleted for this modules:
- block
- color
- Modules that have more than one new css file aren't loaded. For example: block.admin.skin.css or color.admin.skin.css. Probably because they are not called from the modules files. Hope it helps.

Thanks ckrina.

Just fixed the patch.

Other try :P

All files are detected now.

But core/modules/block/block.admin.css and core/modules/color/color.admin.css still aren't deleted.

And the last problem I have detected is that in dblog some path icons need to be updated.

I've made this changes in the patch. Hope it works.

Sorry, uploading the correct one. This one should work.

It seems good form me.
We must take into account that there are other issues where we are working on the same css files (see the summary of this issue).
I will mark it as RTBC. Feel free to change to needs work if you notice something else.

The image URLs in the following styles from moved CSS files need to be updated like "images/hook.png" to "../images/hook.png".

+++ b/core/modules/color/css/color.admin.skin-rtl.cssundefined
@@ -0,0 +1,16 @@
+#palette .down,
+#palette .up,
+#palette .both {
+  background: url(images/hook.png) no-repeat 100% 0;
+}

+++ b/core/modules/color/css/color.admin.skin.cssundefined
@@ -0,0 +1,25 @@
+#palette .down,
+#palette .up,
+#palette .both {
+  background: url(images/hook.png) no-repeat 100% 0; /* LTR */
+}

+++ b/core/modules/color/css/color.admin.skin.cssundefined
@@ -0,0 +1,25 @@
+#palette .lock {
+  background: url(images/lock.png) no-repeat 50% 2px;
+}

+++ b/core/modules/filter/css/filter.admin.skin.cssundefined
@@ -0,0 +1,13 @@
+.filter-help a {
+  background: transparent url(../../misc/help.png) right center no-repeat; /* LTR */
+}

+++ b/core/modules/locale/css/locale.admin.skin.cssundefined
@@ -0,0 +1,34 @@
+#locale-translation-status-form .expand .inner {
+  background: transparent url(../../misc/menu-collapsed.png) left .6em no-repeat;
+}
+
+#locale-translation-status-form .expanded .expand .inner {
+  background: transparent url(../../misc/menu-expanded.png) left .6em no-repeat;
+}

Done!

#30: rename-module-css-1925320-30.patch queued for re-testing.

This is going to need a reroll since we're dropping the change from "theme" to "skin". See http://drupal.org/node/1921610#comment-7366314.

Here's a patch that moves the css files in the dblog module into a css directory.

A number of previous patches included various directory changes that I think we should keep (due to the added css directory). I less certain that some of the previous CSS changes should be rolled back in as well.