[D7] Uyan

1) Please add README.TXT, which describes the module information and configuration.

2) If you want the community reviewer will review your module, then change the status to Need Review.

3) Delete your master branch, you already have your code repository in 7.x-1.x.

4) Prefix your function name _create_uyan_html() to your module name i.e _uyan_create_html().

Also there few indentation and spacing errors. See this
http://ventral.org/pareview/httpgitdrupalorgsandboxdansboy1926022git

Hi dansboy,

The readme file in your module is called README (no extention).
this should be README.txt

Your git link on this page also isn't correct, it should be:
git clone http://git.drupal.org/sandbox/dansboy/1926022.git uyan

Module appears to work but i couldn't create an account on uyan because i can't read there site ;)!

When running the Coder module on your code it still shows some errors, please fix these (see attachment).

For your .info file, you should add a package.

Code seems good, i couldn't find any improvements there.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Seems it is chinese third party comment platform using some of microblogging services of that country.
So there is lack of information in description.
Agree with strakkie, code style looks well.
But I could not confirm module workflow. It is possible to register at http://www.uyan.cc/ and accept web site. But third-party comment form (it generates through js) does not appear on module load.
I have an error at js console:
Failed to load resource http://api.uyan.cc/?url=http%3A%2F%2Fpolygon-3123.rhcloud.com%2Fnode%2F1%23…%2Fimage%2F31b.jpg%3Fitok%3DUdDvcnWc&vid=&tag=&uid=1762647&acl=&2114566463

Thats it, thank you.

You might want to use some theme functions around _uyan_create_html() so people can get the uyan iframe to look the way they want.

Otherwise it seems fine.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Hi

Looked code, all is well. I noticed a few things:

1. The file uyan.info missing parameter "package" (See also wrote to you about it @strakkie)
2. It's not critical, but usually hook - hook_permission cause after hook_menu.

Made review the code and set the module, unfortunately check how the module is not possible, because I do not know Chinese.

Package is optional in a .info file, it will default to "Other" - see https://drupal.org/node/542202#package. It's been over a month in RTBC status now.

Thanks for your contribution, dansboy!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.