The drupal mail functions in the module are out of date. As a result, no mails gets sent out from the module. See http://api.drupal.org/api/function/drupal_mail/5

First argument is now a $mailkey. Doesn't look like $headers are really needed any more, either.

CommentFileSizeAuthor
#6 mailhandler-drupal_mail.patch3.37 KBmfb

Comments

moshe weitzman’s picture

ouch - this will prevent error emails from going out it seems.

moshe weitzman’s picture

Status: Active » Fixed

i went and fixed this without any testing. hope i got it right. it can't be any more broken. note that 6.x is not affected.

acrollet’s picture

seems to work for me now - this issue was affecting my site...

thanks,

Adrian

mfb’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

The Drupal 6 branch *is* affected by this. Although it needs a different patch for http://api.drupal.org/api/function/drupal_mail/6

In my testing on d6, the error message was sent out to scores of invalid email addresses, with each word in the message considered a "To" address (most of them on the server's local domain) and an empty subject and body.

moshe weitzman’s picture

my fixes were to d6. are you sure you are using a version after my fixes? someone reported that hey did work.

mfb’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new3.37 KB

According to http://drupal.org/cvs?commit=125745 the fix was on d5. I attached a patch for d6.

mfb’s picture

By the way this patch is a bit larger than it needs to be; I removed some newlines (\n) from the translatable strings since wrapping and concating of body sections can now be done by core mail functions. If it's important to avoid changing translatable strings I could reroll this.

moshe weitzman’s picture

At first glance, this looks good. I will review and commit soon.

moshe weitzman’s picture

Status: Needs review » Fixed

Committed without any changes or testing. Please report back success or failure. Code looks good.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.