[D7] Book Outline Block

Welcome,

please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxbalsama1929616git

Just a couple of things from looking over this module. You have a .uninstall file with your hook_uninstall call, this file will need to be renamed .install instead.

I think your module will need to have a dependancy on the 'block' module. And you still have a master branch, you should get rid of that and then change your default branch in your version control tab of your project page.

I suggest few minor changes:

1. Replace bookoblock_is_book_node function with book_outline_node_book:

function book_outline_node_book() {
  $node = menu_get_object();
  if ($node && isset($node->book)) {
    return $node->book;
  }
  return FALSE;
}

2. use $book['menu_name'] instead of book_menu_name($book['bid']);

3. I need to massage array I get from menu_tree_output. I did not find a hook to do this. May be you could add a hook, that will help to extend based on your module. Now I had to copy your code and insert a call to custom function that modifies link titles.

Hope this helps and good luck with this module.

Based on what bulat said above I changed the status back to needs work.

But other than that it looks good to me.

Commit looks good. Thanks.

for #3 I have added comment to show what exactly I wanted to achieve with hook - http://drupal.stackexchange.com/a/65814/9753

Possibly there is another way to do that without custom hook.

Sure, I am new to review process, hope you are not waiting on me, cause I am happy with the code.

Sorry for the delay, make sure to complete your review bonus as strongly recommended in the application documentation.

I don't understand why we need this module - I can just use book.module's block, configure it to "Show block only on book pages" and be done with it? Then the block will only show up on book pages and it will only show the current book outline. What am I missing?

Yep, let's close this application. Feel free to get back to us anytime whenever you have a new project that you want to promote.

Deleting the sandbox is totally up to you, as you like it.

Updated PAR review list

The core book block does not show an expanded tree:

while this module does:

Is there any chance to have it approved as a module in the future?

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Adding D7 to title

This application is closed because the module is not necessary.