Wysiwyg + Media module support

Please list here what patch do we need to make to make it work.

I also have an error : Undefined index: mythemename in picture_wysiwyg_plugin() (line 1222 picture.module). after I enabled the 'Make images responsive with the picture module' setting in my site's text format.

The comment on the picture_image_uri() function stated that the img src can be either http://, https://, or root relative /.

@param
 *   Image src starting with http://, https://, or root relative /.
 *   It must point to a local file.

But it's not so because i realised that when an absolute path is used this particular function will return an error causing the validation code to return an error because the $needles[$scheme] will not be at position 0.

    // Check whether the file stream directory is at the beginning of
    // the image src. Use === since strpos could return false.
    if (strpos($src, $needles[$scheme]) === 0) {
      $matches[$scheme] = $needles[$scheme];
    }

When i tried using a relative path, the validation passed and $needles[$scheme] is indeed at position 0 therefore I've added 2 lines of code to make sure to remove the domain name of from the $src when an absolute path is used. Not sure if this is the best way to solve it but $key[0] remained empty even when i'm using a relative path.

    // Convert absolute path to relative path
    $key = explode($needles[$scheme], $src);
    $src = str_replace($key[0], '', $src);
    
    // Check whether the file stream directory is at the beginning of
    // the image src. Use === since strpos could return false.
    if (strpos($src, $needles[$scheme]) === 0) {
      $matches[$scheme] = $needles[$scheme];
    }

This is not quite a media module issue but images that is added through the add media button are in absolute path hence i think this should be useful to those that are having issue using the add media button.

Can you try using parse_url, something like

$src = parse_url($src, PHP_URL_PATH);

it should work for both absolute and relative paths.

Better title, since this is about wysiwyg + media

Here's the second piece of the puzzle. The Media module needs to be told to accept the custom attributes. Patch attached.

parse_url

definitely looks like a better solution for checking the 'Drupal URI' (not included in this patch).

Oops, forgot to make patch project relative. BTW, this patch is against media-7.x-2.x-dev from today. Revised patch attached.

#7 is a patch for media, so I created #1937106: Add extra attributes to wysiwyg_allowed_attributes to support picture integration

Here's the new patch file as suggesested by attiks at #4 instead of the previous hack.

Tested:

$src1 = '/sites/all/default';
$src1 = parse_url($src1, PHP_URL_PATH);
$src2 = 'http://picture.dev/sites/all/default';
$src2 = parse_url($src2, PHP_URL_PATH);
echo $src1 . '<br>';
echo $src2;

and it returns:

/sites/all/default
/sites/all/default

Which looks great!

I added an image with Media in WYSIWYG. But when I double-click the image to select the Picture groups the entire page is greyed out but no popup window comes up. Same is happening if I just click the Image button instead of Add media.

I have the dev version of Picture as of today, and have enabled "Make images responsive with the picture module" in the Text formats, and put that after "Convert Media tags to markup" int he Filter processing order.

Do need something more to make Picture work with Media in WYSIWYG? Do I need to apply the patch for Media in #7?

#12 can you create a new issue please and link it with this one?

#12 you probably need the patch for media