I implemented hook_i18n_object_info_alter() to change the key attribute on various i18n objects. Unfortunately, the code in i18n_menu and i18_taxonomy is still using mlid and tid respectively to lookup string translations. The patch I am submitting uses the i18n object info key attribute instead.

CommentFileSizeAuthor
#1 1933690-menu_links-and-taxonomy-keys.patch2.83 KBinfojunkie

Comments

infojunkie’s picture

infojunkie
Location Vancouver
commented
StatusFileSize
new 1933690-menu_links-and-taxonomy-keys.patch2.83 KB

Patch attached.

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Active » Needs review
infojunkie’s picture

infojunkie
Location Vancouver
commented
Title: hook_i18n_object_info_alter() "key" attibute not honored » hook_i18n_object_info() "key" attribute not honored

(Fixing typo in title)

jose reyero’s picture

jose reyero commented
Status: Needs review » Fixed

Ok, committed, thanks.

Btw, there was another similar issue #1644312: i18n_taxonomy_term_name should account for i18n_object_info key

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fix typo

Status: Closed (fixed) » Needs review

alvar0hurtad0 queued 1: 1933690-menu_links-and-taxonomy-keys.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 1933690-menu_links-and-taxonomy-keys.patch, failed testing.

infojunkie’s picture

infojunkie
Location Vancouver
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)

This has been already committed.