If I change the table background colour it isn't saved.
After saving the current settings the config page reloads and the old settings are still there.

Comments

laszlo.laszlo’s picture

I've got the same problem with the color picker.
Where can I found the saved background color in the database?

vacilando’s picture

Category: bug » support

Tested it on my system, works fine. It definitely will not be a bug.

Do similar forms save all right in your system(s)? I'd suspect a wider problem with your Drupal install. I recently saw something similar after upgrading to Drupal 5.3.. eventually I found it was due to a module that was incompatible with that version...

laszlo.laszlo - such variables are stored in table "variable".

jaegerschnitzel’s picture

I searched my database and I found no item with the name "laszlo"
and yes all other options are fine for me

I installed drupal 5.3 a week ago on a empty webspace and database

vacilando’s picture

jaegerschnitzel - you should look in table "variables" for entries starting "brilliang_gallery..."

"laszlo.laszlo" is an user name -- I was just answering the other user's question (see above)

jaegerschnitzel’s picture

oh sorry ;)
I found the value and changed it to s:7:"#FFFFFF";

but the background is still black...
yes I cleaned my cache ;)

EDIT: some idea?

Nitagob’s picture

That is my solution (edit the brillant_gallery.module) for the problem (not a Brillant Gallery bug, possibly):

$form['brilliant_gallery_bcgcolour'] = array(
// '#type' => 'colorpicker',
'#type' => 'textfield',
'#title' => t('Table background colour'),
'#default_value' => variable_get('brilliant_gallery_bcgcolour', '#000000'),
'#size' => 8,
'#maxlength' => 7,
'#description' => t("Pick colour of the background of the table that holds the images.")
);

Of course, no any colorpicker since than, but it's unnecessary for me.

jaegerschnitzel’s picture

ok I changed my code in brillant_gallery.module and now I can set the colour manually

but still the problem that the background ist black whatever I enter...
the value is not accepted

Nitagob’s picture

Btw, try to rename bordercolor to bgcolor in the following string at render_brilliant_gallery() function in the .module file (there are no reason to set bordercolor there anyway - border width is zero, isn't it?)):

        $result .= '<!-- Brilliant Gallery Table Beginning --><table border="0" rules="none" frame="box" cellpadding="0" cellspacing="0" bordercolor="' . $bgcolour . '"';
Nitagob’s picture

Or you even cannot see the colour value updated at the corresponding administration textfield??!

jaegerschnitzel’s picture

no effect

this is stored in my DB:
brilliant_gallery_bcgcolour s:7:"#ffffff";

is this right?
if so I think the DB is not readout correctly by the script

Nitagob’s picture

BG uses standard Drupal API function variable_get('brilliant_gallery_bcgcolour', '<default_value_here>')
so probably the function works incorrectly.

Try to check versions of installed modules (especially kernel's required and additional), and the Drupal's error log.

jaegerschnitzel’s picture

strange thing

now it works, but only after I deactivated and activated the Colorpicker module
changing the backgroundcolour shows no effect until I deactivate and activate the Colorpicker module

Nitagob’s picture

"It works?? Don't change it!" ;))

vacilando’s picture

Status: Active » Fixed

Unfortunately, this problem appeared after Colorpicker module changed the way forms have to be built.

I have now modified this module's code as needed. Update Brilliant Gallery to version 2.15 and Colorpicker will work again.

Cheers,

Tomáš / Vacilando

jaegerschnitzel’s picture

great now it works
thanks :D

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

ziadrupal’s picture

Title: Table background colour not saved » warning: Missing argument 8 for render_brilliant_gallery()
Assigned: jaegerschnitzel » ziadrupal
Status: Closed (fixed) » Active

The picture are displayed, but on content there are warnings like these:

warning: Missing argument 8 for render_brilliant_gallery(), called in C:\xampp\htdocs\drupal\sites\all\Modules\brilliant_gallery-5.x-3.1\brilliant_gallery\brilliant_gallery.module on line 59 and defined in C:\xampp\htdocs\drupal\sites\all\Modules\brilliant_gallery-5.x-3.1\brilliant_gallery\brilliant_gallery.module on line 219.

what's happen?

johnhorning’s picture

I am getting the same error message.

warning: Missing argument 8 for render_brilliant_gallery(), called in /home/rivulcom/public_html/sites/all/modules/brilliant_gallery/brilliant_gallery.module on line 59 and defined in /home/rivulcom/public_html/sites/all/modules/brilliant_gallery/brilliant_gallery.module on line 219.

whatthestink’s picture

they forgot to give captionyestnotext a default value so change:

render_brilliant_gallery( $thisfolder = '', $colcountoverride = '', $widthoverride = '', $sortoverride = '', $maximumnumbertoshow = '', $colouroverride = '', $beginfromoverride = 1, $captionyesnotext) {

to

render_brilliant_gallery( $thisfolder = '', $colcountoverride = '', $widthoverride = '', $sortoverride = '', $maximumnumbertoshow = '', $colouroverride = '', $beginfromoverride = 1, $captionyesnotext = '') {

and it should work like a champ

johnhorning’s picture

Thanks - that does the trick!

vacilando’s picture

Status: Active » Fixed

Yes, a forgotten default value. Fixed in version 3.2.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.