There was no objection to switching to HAL, and there is a patch to switch REST module to support HAL by default, so it should be safe to remove JSON-LD module now.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 1935548-13-remove-jsonld.patch | 45.42 KB | linclark |
| #9 | drupal-1935548-9.patch | 44.94 KB | c4rl |
| #4 | 1935548-04-remove-jsonld.patch | 48.22 KB | linclark |
| #2 | 1935548-02-remove-jsonld.patch | 47.54 KB | linclark |
| #1 | 1935548-01-remove-jsonld.patch | 108.03 KB | linclark |
Comments
Comment #1
Anonymous (not verified) commentedThis patch removes the module and the entry in MAINTAINERS.txt.
Comment #2
Anonymous (not verified) commentedThis patch is a reroll, plus it removes the routes for the RDF site specific vocabulary... we don't have an RDF serialization to serve them in at this point.
Comment #4
Anonymous (not verified) commentedNeeded to remove a line in RdfBundle.
Comment #5
Crell commentedAlas, poor JSON-LD. I knew it well, Horatio...
Normally we don't kick modules out of core unless there's a contrib module to inherit them. This is a new module so I don't know if that applies here, but should we make sure this code has a new home in contrib before we ax it here?
Comment #6
Anonymous (not verified) commentedI'd say not. I think that we don't want to use the drupal_jsonld custom media type anyway, and the code should be refactored significantly now that $context is part of the Serializer::serialize function signature. Its probably better to start from scratch.
Comment #7
damien tournoud commentedTo be honest, I am not sad to see this go, but I am looking forward to the next iteration in contrib!
Comment #8
alexpottNeeds a reroll since #1939660: Use YAML as the primary means for service registration landed
Comment #9
c4rl commentedRe-rolled
Comment #11
c4rl commented#9: drupal-1935548-9.patch queued for re-testing.
Comment #13
Anonymous (not verified) commentedI'm guessing that the reroll failed because the RouteSubscriber I had removed from RDFBundle in my previous patch made it in to the .yml file. This patch removes that from the .yml file, so we'll see if it works.
Comment #14
moshe weitzman commentedAnd, we're green. All removals so not much to review.
Comment #15
alexpottCommitted f406799 and pushed to 8.x. Thanks!
The patch didn't apply cleaning due to changes in json.info.yml also core/modules/jsonld/jsonld.services.yml was being left behind… fixed during commit as this is a straight removal.
I checked for change notices to update... there are none.