Closed (fixed)
Project:
File Entity (fieldable files)
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Mar 2013 at 23:18 UTC
Updated:
30 Apr 2013 at 19:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
redndahead commentedHere is the patch.
Comment #2
aaron commentedI am unable to reproduce the error, as the previous button does not fail for me on the 7.x-2.x branch without the patch. However, the patch itself looks fine to me, so I will mark this rtbc.
Comment #3
redndahead commentedto reproduce you would have to have a required field on the file_entity
Comment #4
aaron commentedI did that. What I did was enabled the file entity and media modules, set up a file field on the article node type, made it required, and then uploaded a file into the field. Maybe I have misinterpreted what this patch is affecting.
Comment #5
redndahead commentedAhh what I meant was go to the video or image, etc. file_entity and add a required field there.
admin/structure/file-types/manage/video/fields
Comment #6
aaron commentedThank you for the clarification. I have tested this more thoroughly now, and there are still some issues that I see. First, after I mark the alt text field of the image file type as required, and then submit an image, the previous buttons works if I fill in the field with a value. That is regardless of whether I have applied the patch or not. If I do not fill in the field, then it fails both with and without the patch, which is what I would expect. Secondly, and this is a more serious issue, but perhaps out of scope for this issue, after I clicked the next button again, the value for the alt text field has been blanked, both with and without the patch applied.
Comment #7
redndahead commentedHmm that's odd it stopped working for me too. I wonder why that is.
Comment #8
redndahead commentedI missed a step.
Comment #9
redndahead commentedWhoops let's combine those.
Comment #10
devin carlson commented#9 looks good; I've done the same in other multi-step form "wizards". It just needs to incorporate the new step added in #1580820: Provide interfaces for selecting stream wrappers during file upload and converting files between stream wrappers.
Comment #11
devin carlson commentedCommitted #10 to 7.x-2.x.