URLs longer than 80 characters get truncated. I discovered this after installing the module, so here's how I fixed it:

  1. Added '#maxlength' => 255, to path_redirect.module line 181

    2. ;

  2. Went into phpMyAdmin and changed the redirect field to varchar(255).

Presumably path_redirect.install would need to be fixed too.

Note that this is very similar to an issue for the 5.x version.

CommentFileSizeAuthor
#4 path_redirect-4.x-1.x_maxlength_4.patch4.69 KBHorsePunchKid
#3 path_redirect-5.x-1.x_maxlength_3.patch989 bytesHorsePunchKid
#3 path_redirect-6.x-1.x_maxlength_3.patch981 bytesHorsePunchKid
#2 path_redirect-4.x-1.x_maxlength_2.patch4.53 KBHorsePunchKid

Comments

HorsePunchKid’s picture

HorsePunchKid commented
Assigned: Unassigned » HorsePunchKid

Thanks for submitting this issue. In fact, there are still a number of missing maxlengths and such in the 5.x and 6.x branches, too. These can lead to either errors on insert or silent truncation. I'll get patches ready soon!

HorsePunchKid’s picture

HorsePunchKid commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new path_redirect-4.x-1.x_maxlength_2.patch4.53 KB

Please try out this patch. I've tested it on my D4 test site, and the upgrade went smoothly. Patches for D5 and D6 should be more trivial, since the schema is already updated.

HorsePunchKid’s picture

HorsePunchKid commented
Version: 4.7.x-1.x-dev »
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new path_redirect-6.x-1.x_maxlength_3.patch981 bytes
new path_redirect-5.x-1.x_maxlength_3.patch989 bytes

Here are patches for 5.x and 6.x.

HorsePunchKid’s picture

HorsePunchKid commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new path_redirect-4.x-1.x_maxlength_4.patch4.69 KB

Actually, the patch for 4.x should just use the same path_redirect_update_1 that 5.x uses. This patch does that and also updates the default redirect type to match that in 5.x (301 permanent).

HorsePunchKid’s picture

HorsePunchKid commented
Status: Reviewed & tested by the community » Fixed

I've committed these patches to the respective branches.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.