Convert the node RSS feed to a display of the frontpage view

Let's see how much is broken.

+++ b/core/modules/node/config/views.view.frontpage.ymlundefined
@@ -139,8 +138,19 @@ display:
+langcode: und

Didn't we just decided to always use a default language 'en' and not und? Or am I mixing issues?

This should fix maybe most of them.

Another try.

Fixed all the remaining failures.

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Tests/AggregatorRenderingTest.phpundefined
@@ -81,9 +81,10 @@ public function testBlockLinks() {
+    $view = entity_load('view', 'frontpage');

Are we still 'allowed' to do this? I'm just not sure anymore.

+++ b/core/modules/node/config/views.view.frontpage.ymlundefined
@@ -138,8 +137,19 @@ display:
+      path: rss.xml

I guess this is what it currently is in D7, /node/rss or something would be better imo. Out of scope though I think.

Let's see what the bot thinks anyway..

I guess this is what it currently is in D7, /node/rss or something would be better imo. Out of scope though I think.

Yeah we can discuss that, though I don't hink it's worth to change, especially because people's RSS reader already point to the location, so they have to change the location which is bad in my oppinion.

Seems like a random failure.

#8: drupal-1940306-8.patch queued for re-testing.

I have just tested this on my local and it works fine. If this comes back green, this is ready to go. I think it should do as that failure did look pretty random.

As I said....

Lovely!! :D

Seems like we might need an update function though to get rid of all those old crufty variables we no longer need? :) And/or pre-populate the view settings with those values.

The problem here is that this variable "items.limit" is still used by aggregator module.

./core/modules/aggregator/lib/Drupal/aggregator/Tests/AggregatorTestBase.php:139:    $feed_count = db_query_range('SELECT COUNT(*) FROM {node} n WHERE n.promote = 1 AND n.status = 1', 0, config('system.rss')->get('items.limit'))->fetchField();
./core/modules/aggregator/aggregator.pages.inc:447:    $result = db_query_range('SELECT i.*, f.title AS ftitle, f.link AS flink FROM {aggregator_category_item} c LEFT JOIN {aggregator_item} i ON c.iid = i.iid LEFT JOIN {aggregator_feed} f ON i.fid = f.fid WHERE cid = :cid ORDER BY timestamp DESC, i.iid DESC', 0, $rss_config->get('items.limit'), array(':cid' => $category->cid));
./core/modules/aggregator/aggregator.pages.inc:452:    $result = db_query_range('SELECT i.*, f.title AS ftitle, f.link AS flink FROM {aggregator_item} i INNER JOIN {aggregator_feed} f ON i.fid = f.fid ORDER BY i.timestamp DESC, i.iid DESC', 0, $rss_config->get('items.limit'));

Yeah. I think if we want to add anything for the upgrade path we should explore that in a follow up maybe.

Ok, let's go ahead and open a follow-up for the general category of "What to do with old settings that related to things that have now been converted to views."

In the meantime...

Committed and pushed to 8.x. Thanks!

Opened a follow up: #1955760: [Meta] Convert aggregator pages/blocks to views