When I rate a comment down, the widgets along with the text of the comments dissapear. I don't think that the comment get's burried though, because it doesn't appear in the "burried comments list". Also the "Thank you" that is supposed to appear after a vote, still appears immediately on the right side of the voting widgets.

I'm currently using simple_karma 1.9 and Jquery 1.2.1 (I replaced the file manually with the one in karma installation package).

CommentFileSizeAuthor
#4 ff1.jpg24.24 KBSnowflake1
#4 ff2.jpg22.4 KBSnowflake1
#4 ie1.jpg76.58 KBSnowflake1
#4 ie2.jpg34.76 KBSnowflake1

Comments

mercmobily’s picture

mercmobily commented

Hi,

About this:

"When I rate a comment down, the widgets along with the text of the comments dissapear. I don't think that the comment get's burried though, because it doesn't appear in the "burried comments list""

This is actually a feature...! If you bury a comment down, I doubt you want to see it :-D
If you think this should be configurable, please add a "feature request".

About this one:

"Also the "Thank you" that is supposed to appear after a vote, still appears immediately on the right side of the voting widgets."

...? There is no "thank you" anywhere... there is no "thank you" string in the karma module! Can you please send a screenshot, and (even better) a link to the site so that I can have a look?

Thanks,

Merc.

Snowflake1’s picture

Snowflake1 commented

Hello,

thank you for your reply. Actually I kinda failed to point out clearly where the problem lies. Trying to explain it in a different way: when I went on drigg.org I created an account to check how the karma module works when someone votes down a comment. I found out that making the comment dissapear is indeed intended, however on drigg.org there is a button that appears allowing you to reexpand the comment should you wish to. And I don't get that button. In my case just the widgets and the text dissapear.

Furthermore the "Thank you" I was referring to is indeed not in the code, but it is the text I indicated in the options to appear _after_ someone cast a vote. Unfortunately that text appears straight away, on the right side of the widgets (even before I cast a vote).

And one last thing: is it normal that the menu items that appear with karma (burried comments / users by karma) are not configurable over admin/build/module? As for example I'd love to rename the menu item "users by karma" to "rankings" and I'd like to transform it into a primary link.

Thank you,
SF

mercmobily’s picture

mercmobily commented

Hi,

Master question: which browser are you using?
Now...

Point 1) :

"thank you for your reply. Actually I kinda failed to point out clearly where the problem lies. Trying to explain it in a different way: when I went on drigg.org I created an account to check how the karma module works when someone votes down a comment. I found out that making the comment disappear is indeed intended, however on drigg.org there is a button that appears allowing you to reexpand the comment should you wish to. And I don't get that button. In my case just the widgets and the text dissapear."

I cannot replicate this.
Questions:

1) Are you absolutely dead sure you are using the LATEST javascript code, after clearing the cache?
2) Can you please give me a web site that has this problem, so that I can have a look?

Point 2):
The is _no_ thank you when you cast a vote with the new version of simple_karma! This tells me that maybe you're using a cached Javascript. Please check! Tricks to reload the javascript: 1) Press F5 to reload the page 2) Load the Javascript DIRECTORY in the browser (you can find the source in the page source)

Point 3):
Those strings are not configurable. There is a point where we had to stop making things configurable... AND, also, Drupal 6 will allow you to redefine specific strings in your Drupal by changing settings .php. For fsdaily.com, I've actually created a Drupal 5 version of the patch that will be available in Drupal 6 ( http://drupal.org/node/131061 ). Please let me know if you're interested. But, it's a different issue - please ask it as a feature.

Bye,

Merc.

[EDIT: I've added the patch to the discussion here, if you're interested: http://drupal.org/node/131061
)

Snowflake1’s picture

Snowflake1 commented
StatusFileSize
new ie2.jpg34.76 KB
new ie1.jpg76.58 KB
new ff2.jpg22.4 KB
new ff1.jpg24.24 KB

Update:

I'm using Firefox currently but that's not where the problem comes from. I found out that it's a theme related issue. On my website I'm using LiteJazz from http://www.roopletheme.com/. It is not entirely compatible for some reason with this module. When you vote down a comment and it dissapears you don't get that button to re-expand it.
When I installed Zen I got that button just fine.

Once that was done I thought everything was fine but actually I discovered quite a few important bugs, mostly browser related. When using firefox (I'm adding screenshots from drigg.org because I disabled karma on my site for now) I get the following errors:

http://drupal.org/files/issues/ff1.jpg (the highest karmic users box looks messy)

http://drupal.org/files/issues/ff2.jpg (when two comments get rated down and when I click several times on expand/bury, it blocks, looks weird and doesn't work anymore)

http://drupal.org/files/issues/ie1.jpg (three bugs here: vote up/down widgets are not next to the rating: they show after a line break / the avatars in the highest karmic user block hide the names partly / the best published scoops block [yeah I know that's drigg not karma] doesn't show the title and the rating on the same height)

http://drupal.org/files/issues/ie2.jpg (navigation bar is completely bugged out in IE, not sure if this is related to karma though, prolly not)

--------------

"Those strings are not configurable. There is a point where we had to stop making things configurable... AND, also, Drupal 6 will allow you to redefine specific strings in your Drupal by changing settings .php. For fsdaily.com, I've actually created a Drupal 5 version of the patch that will be available in Drupal 6 ( http://drupal.org/node/131061 ). Please let me know if you're interested. But, it's a different issue - please ask it as a feature."

---> The problem is that at the moment you can't even turn off those menu items. Just a box to tick in the options of Simple Karma to enable or disable menu items would do the trick largly. People could then just add menu items themselves by using the url of /karmausers.

--------------

Last thing: I know that a lot of this doesn't really belong in support request, but I don't really want to spam and create a seperate issue/bug report/feature request for every single thing. Unless you really think it's necessary.

Thank you,

SF

Snowflake1’s picture

Snowflake1 commented

I forgot to add that the two first screenshots are firefox problems and the last two are problems in internet explorer.

mercmobily’s picture

mercmobily commented

Hi,

OK, about this one:

"http://drupal.org/files/issues/ff1.jpg (the highest karmic users box looks messy)"
-- We are aware of the problem. Fixing it in the next day or so

"http://drupal.org/files/issues/ff2.jpg (when two comments get rated down and when I click several times on expand/bury, it blocks, looks weird and doesn't work anymore)"
--- I can't replicate this problem. Can you please give me an exact URL, and can you please make DEAD sure that you don't have an old JS in cache?

"http://drupal.org/files/issues/ie1.jpg (three bugs here: vote up/down widgets are not next to the rating: they show after a line break / the avatars in the highest karmic user block hide the names partly / the best published scoops block [yeah I know that's drigg not karma] doesn't show the title and the rating on the same height)"

Will need to look into this one too

"http://drupal.org/files/issues/ie2.jpg (navigation bar is completely bugged out in IE, not sure if this is related to karma though, prolly not)"
--- Apart from the fact that now the block on the right is bugged, can you please confirm that in IE the nav bar on http://www.drigg.org is good?

Thanks,

Merc.

mercmobily’s picture

mercmobily commented

Hi,

Showflake, please confirm that the strange "Thank you" issue is resolved/wasn't there.

Bye,

Merc.

mercmobily’s picture

mercmobily commented

"http://drupal.org/files/issues/ie2.jpg (navigation bar is completely bugged out in IE, not sure if this is related to karma though, prolly not)"

This is now fixed, in drigg.org and drigg_distr.tgz

Merc.

mercmobily’s picture

mercmobily commented

"http://drupal.org/files/issues/ff2.jpg (when two comments get rated down and when I click several times on expand/bury, it blocks, looks weird and doesn't work anymore)"
--- I can't replicate this problem. Can you please give me an exact URL, and can you please make DEAD sure that you don't have an old JS in cache?

This is "solved" - meaning, I took this functionality off Drigg for the time being, since it's not essential and we have 3582648264 to deal with first.

Merc.

mercmobily’s picture

mercmobily commented

Hi,

About this one:

""http://drupal.org/files/issues/ff2.jpg (when two comments get rated down and when I click several times on expand/bury, it blocks, looks weird and doesn't work anymore)"

I disabled the show/hide functionality for the time being. I'd rather focus on much more important stuff. I will add this later.

Merc.

mercmobily’s picture

mercmobily commented
Status: Active » Closed (fixed)

Hi,

This bug got too messy. Most of the issues are resolved - the only parts are NOT resolved are IE-specific ones, for which I opened a different bug:

http://drupal.org/node/194357

Reporters: please check that the new bug has all of the outstanding problems (once you've downloaded 1.10). If not, please open a NEW BUG with a screenshot.

Bye,

Merc.