regarding the following code in gmap_settings_ui.inc, which is shown on /admin/config/services/gmap :

function gmap_admin_settings($form, &$form_state) {
...
if (file_default_scheme() != 'public') {
  $form['initialization']['gmap_private_markerfile'] = array(
      '#type' => 'textfield',
      '#title' => t('Path to gmap_markers.js'),
      '#description' => t('You are using the <em>Private</em> download method. For markers to work properly. you must press the <em>Regenerate</em> button, manually copy js/gmap_markers.js from the files directory to a location accessible by the webserver, and enter the file path relative to the Drupal root (including the filename) in this field. Example: <em>sites/default/misc/gmap_markers.js</em>'),
      '#default_value' => variable_get('gmap_private_markerfile', ''),
    );
  }

a) I use private schema, and my system works fine without this setting. IMO this is a d6-residu.
b) although it uses variable_get('gmap_private_markerfile', '') , I cannot find where it is used again.

Can this be removed altogether, or does it still have a function?

Comments

podarok’s picture

Category: bug » task
Issue tags: +Needs tests

try to remove this code and check tests via Testing module.

This form covered by test without additional checks
http://drupalcode.org/project/gmap.git/blob/HEAD:/tests/gmap.test#l128
(FYI line 128)
possibly we should add a few more checks before removing this variable

Anyway this looks like task, not a bug

johnv’s picture

It was introduced recently, in #1459606: [CLOSED] Backport from D7 to use Google maps API V3 for D6 6.x-2.x-dev. And that patch does not contain any code actually using the feature.
Was it unintentionally in the patch?

podarok’s picture

#2 yes, it was unintentionally

podarok’s picture

addition to this issue
we should create hook_uninstall with removal of this variable for upgrade path

PS. Thinking a little about that variable - it was possibly for using gmap with Private file system option
Looks like during some update in the past the code with the feature was removed... (

johnv’s picture

yeah, D6 was all-or-nothing Private/public.

OTOH, It might be a useful feature for this case: #1098030-2: Map markers do not display on node view when site is in a subdirectory
There are some other issues with subdomains as well:
- #1938006-7: Link to macro page in GMap style plugin. Handle subdirectory install path.
- some other recent issue with patch ...
But there should be a generic way/function to create URL's with subdomains.

podarok’s picture

due to #5 updated follow up issues summaries

socialnicheguru’s picture

Issue summary: View changes

I am using a private file system.
I have gmap_markers.js being written to my public files directory. I guess this explains why.

So will it be removed or the feature completed