It would be great if anonymous users are able to optionally fill out their names before they enter the chat. If not, the 'guest-x:' label is used.

CommentFileSizeAuthor
#4 chatroom_anon_name_194170.patch6.17 KBNick Robillard

Comments

Anonymous’s picture

Anonymous (not verified) commented
Version: 5.x-1.x-dev » 6.x-2.x-dev

i'm not opposed to this feature request, but i'm not interested in working on the 5.x branch.

bumping to latest branch.

artscoop’s picture

artscoop commented

Hi,
Well, it would be great to have this feature in D6.

shane birley’s picture

shane birley commented

Anonymous user nick name update would be cool. Is there any concern over exploitation on this?

Nick Robillard’s picture

Nick Robillard commented
Version: 6.x-2.x-dev » 6.x-2.12
Status: Active » Needs review
StatusFileSize
new chatroom_anon_name_194170.patch6.17 KB

I've implemented this.

Some notes:
1) I stored the anon name data in the chatroom_msg table since a user could change their name in a later message.
2) I'm still appending the guest id to the anon name to avoid confusion if someone changes their name mid-chat.
3) I fixed an unrelated issue where the guest prefix vanished from anon messages after they've left. ie: i would see "9: (message)" instead of "guest-9: (message)". I did this by removing !in_array($message->sid, $guest_sids) from the condition in function chatroom_chat_load_messages_helper in chatroom.module. I'm sure there's a good reason it was there but i don't see any side effects after removing it.

Anonymous’s picture

Anonymous (not verified) commented

thanks! i'll review this later today.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

thanks! committed this (slightly modified) here:

http://drupal.org/cvs?commit=491446

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.