Drujax enables you to create ajax loaded content requests. This is perfect for developers who want to create websites with page transitions through jquery or any other javascript animation library. The module makes this possible by adding an extra content.tpl.php where you can put the main part of your page.tpl.php (for example everything except your footer and header). The output of the content.tpl.php wil be added to a $content variable in your page.tpl.php. All the content links will automaticly be processed with javascript and provoke an ajax call. Drujax also makes use of jquery address push states to minimalise SEO and usabilty issues.

Drupal version: 7
project page: http://drupal.org/sandbox/samueljoos/1941270
git: http://git.drupal.org:sandbox/samueljoos/1941270.git

Reviews

http://drupal.org/node/1942536
http://drupal.org/node/1941608
http://drupal.org/node/1925870

Comments

denisz’s picture

denisz commented
Status: Needs review » Needs work

Hi, samueljoos.

First of all you must resolve issues from automatic testing http://ventral.org/pareview/httpgitdrupalorgsandboxsamueljoos1941270git

Samuel Joos’s picture

Samuel Joos commented
Status: Needs work » Needs review

I resolved all of the issues except one false positive on an ajax regex string.
http://ventral.org/pareview/httpgitdrupalorgsandboxsamueljoos1941270git-...

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)

luco’s picture

luco commented

hi samueljoos,

I like the idea of your module. sounds promising! however, you should give users an option to disable it on certain pages (namely using a textarea in which users input their preferred addresses for enabling the effect).

also, your TPLs should be stored in a folder called "theme".

I installed your module and the library at /sites/all/libraries/jquery_address/jquery.address.min.js as per instructions, but still got the following error:

Notice: Undefined index: HTTP_X_REQUESTED_WITH in drujax_is_ajax() (line 119 of /yadayada/sites/all/modules/custom/drujax/drujax.module).

cheers,
Luciano

Samuel Joos’s picture

Samuel Joos commented

Thx Luciano,

Great idea to disable it for certain pages. I added an admin settings page based on how the paths in blocks are configured.
So you have the option to disable it on certain pages or to only enable it for certain pages.

I also fixed the error and putted the templates in the theme folder.

Samuel Joos’s picture

Samuel Joos commented
Issue tags: +PAreview: review bonus

I reviewed a couple of projects and added some default ajax handlers which can be set in the admin.

luco’s picture

luco commented

may I suggest a change in your .info file?

"Provides a way to load your page content via ajax through a separate template."

the path exclusion setting works as intended, but I still can't get the drujax effect working. I placed its TPL files in my theme's templates folder.

my test theme is a subtheme of Zen. I also tried with Bartik. no joy. sure I'm missing something... can you help me get it working? :)

Samuel Joos’s picture

Samuel Joos commented

HI Luco,

Thx for your feedback english isn't my native language so it's great to have some feedback on my copy.
Did you select een animation preset? Otherwise you won't notice very much. I tested it with Omega and bartik and that worked.
Have you edited your page.tpl.php and added print $content instead of your "main" content?
If so does it render your main content?

Gr,
Samuel

20th’s picture

20th commented
Status: Needs review » Reviewed & tested by the community

tl;dr RTBC

I cannot find any particular problems with this module, except maybe inconsistent use of string quotes. The code uses both single and double quotes, sometimes even mixes them on the same line:

'#default_value' => variable_get("drujax_wrapper", "drujax-main"),

It would be better to use just one type of quotes.

Automatic testing found a missing new line character in the .info file. This is not something serious, but it will be better to fix it anyway:

FILE: /var/www/drupal-7-pareview/pareview_temp/drujax.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

The other error in the automatic testing report is a false-positive.

But in general, this module looks good to me: installation is straightforward and the module works as promised. I had to modify the markup of my theme a little to make Ajax work properly, but it was not difficult. This module is targeted at developers anyway.

One thing that I have noticed is that this module breaks Gallery Formatter that I use on my site. Gallery formatter uses <a> tags to navigate between slides of the gallery, but Drujax will attach to them too. So when I click on the Next button, Drujax pops up Page not found alert window.

Also, I could not figure out the purpose of the drujax_var function. It looks like it is not used in any useful way. Is it some dead code from previous version?

Samuel Joos’s picture

Samuel Joos commented

Hi 20th,

Thx for your review. I'll make some changes as soon as possible. I have indeed been a bit sloppy with my quotes.

It would probably better if I would add a setting to change the link selector in the admin and maybe a field where you can add classes that can't be used by jquery.address.

Drujax_var isn't dead code but by default it doesn't do much either. I'll give you an example where it could be handy to use. Let's say you want to add a different color per page using a cck field. When you don't use drujax or any other ajax module you could just add it with some inline css in your page.tpl.php. This is isn't possible with drujax because de page.tpl.php doesn't refresh. What you can do in drujax is passing your color to the json object via drujax_var("color",$color);
and you could then set the color with jQuery: $("body").css("background-color",data.color);

Samuel Joos’s picture

Samuel Joos commented

I adjusted the quotes and added an extra field for a custom link selector.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

manual review:

  1. drujax_uninstall(): some variables are missing that should be removed as well like drujax_link_selector?
  2. "@params tring $var_name": should be "string".

I really can't say much about the Javascript and how "correct" that works, but I can't find any other blockers either, so ...

Thanks for your contribution, Samuel Joos!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

luco’s picture

luco commented

woohoo! congrats!

Samuel Joos’s picture

Samuel Joos commented

Thanks everybody,

I am glad to be part of this community!

Gr,
Samuel

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added reviews