Instead of having the saving & deleting queries in the menu link hooks, maybe they could have their own functions, like menu_per_role_item_settings_save() and menu_per_role_item_settings_delete() etc. (or similar).

This would be preferable for other modules to use as opposed to them directly calling the menu_per_role implementations of those hooks.

Opinions?

Happy to make a patch if you agree.

Comments

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

Hello,

I will update the code to fix coding standards and best practices in #2907758: Drupal 7 version.

If you want to provide a patch after that, no problem.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Closed (outdated)

Closing as there is no reply since many years.

Feel free to re-open.