Problem/Motivation

Running "drush make build-spark.make /path/to/wwwroot" will run drupal-org.make and it is supposed to download the json2.js within the libraries folder (/path/to/wwwroot/profiles/spark/libraries/json2/)

Proposed resolution

A change is needed in drupal-org.make, line 129, to:
libraries[json2][download][url] = https://raw.github.com/douglascrockford/JSON-js/master/json2.js
So we can download the correct Javascript library.

CommentFileSizeAuthor
#2 spark-fix-to-json2-library-1946274-1.patch625 bytesjmcoimbra

Comments

jmcoimbra’s picture

jmcoimbra commented
Title: drupal-org.make brings HTML from https://github.com/douglascrockford/JSON-js/blob/master/json2.js » drupal-org.make brings HTML for json2.js
Issue tags: +JavaScript, +issue, +Libraries, +json2

Updating title to avoid spam filter

jmcoimbra’s picture

jmcoimbra commented
StatusFileSize
new spark-fix-to-json2-library-1946274-1.patch625 bytes
jmcoimbra’s picture

jmcoimbra commented
Status: Active » Needs review

Sorry guys, I am new contributing to Drupal. =)
I don't know the flow of this fix... I think someone other then me must test it.

Thanks

jmcoimbra’s picture

jmcoimbra commented
Status: Needs review » Active
jmcoimbra’s picture

jmcoimbra commented
Assigned: jmcoimbra » Unassigned
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Did github change URL patterns recently? I see currently the new URL works better, but the old one used to work too.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Fixed

Looked at how the raw URL is produced on github and it indeed now points to this new URL. So committed this and fixed the whitelist pattern at http://drupal.org/node/1404070 to allow for this URL form too for this lib.

jmcoimbra’s picture

jmcoimbra commented

Hey, thanks!
The first contribution we never forget ;-)

Automatically closed -- issue fixed for 2 weeks with no activity.