Feeds GCal importer for Feeds module to facilitate importing Google Calendar user's full united feeds instad of single iCal feed. The full feed of feeds seems to be available only through Google API and that was the reason for developing the module/plugin. The module depends on Zend Framework.

The module probably needs improvement to deal a bit better with storing the Google password.

Clone it from git:
git clone --branch master git.drupal.org:sandbox/tramm/1946212.git feeds_gcal
git clone --branch 7.x-1.x git.drupal.org:sandbox/tramm/1946212.git feeds_gcal

Comments

ycshen’s picture

Status: Needs review » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.


FILE: /var/www/drupal-7-pareview/pareview_temp/plugins/FeedsGCalFetcher.inc
--------------------------------------------------------------------------------
FOUND 64 ERROR(S) AND 1 WARNING(S) AFFECTING 30 LINE(S)
--------------------------------------------------------------------------------
 21 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 21 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 23 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 23 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 24 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 24 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 25 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 25 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 26 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 27 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 27 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 29 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 29 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 30 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 30 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 31 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 31 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 33 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 33 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 34 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 34 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 34 | ERROR   | Variable "calFeed" is camel caps format. do not use mixed case
    |         | (camelCase), use lower case and _
 35 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 35 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 35 | ERROR   | catch must start on a new line
 36 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 36 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 37 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 39 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 39 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
 39 | ERROR   | Variable "calFeed" is camel caps format. do not use mixed case
    |         | (camelCase), use lower case and _
 40 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 40 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 41 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 41 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 41 | ERROR   | There should be no white space after an opening "("
 41 | ERROR   | There should be no white space before a closing ")"
 42 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 42 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 42 | ERROR   | Whitespace found at end of line
 43 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 43 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 44 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 44 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 44 | ERROR   | Whitespace found at end of line
 45 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 45 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 46 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 46 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 47 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 47 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 48 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 48 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 48 | ERROR   | Variable "eventFeed" is camel caps format. do not use mixed
    |         | case (camelCase), use lower case and _
 48 | ERROR   | Whitespace found at end of line
 49 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 49 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 49 | ERROR   | Variable "eventFeed" is camel caps format. do not use mixed
    |         | case (camelCase), use lower case and _
 50 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 50 | ERROR   | Line indented incorrectly; expected 8 spaces, found 3
 51 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 52 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 57 | ERROR   | Whitespace found at end of line
 74 | WARNING | Avoid backslash escaping in translatable strings when possible,
    |         | use "" quotes instead
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/plugins/FeedsGCalParser.inc
--------------------------------------------------------------------------------
FOUND 40 ERROR(S) AND 1 WARNING(S) AFFECTING 22 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR   | Missing file doc comment
 12 | ERROR   | No space before comment text; expected "// $tz =
    |         | date_default_timezone_get();" but found "//$tz =
    |         | date_default_timezone_get();"
 13 | WARNING | There must be no blank line following an inline comment
 13 | ERROR   | No space before comment text; expected "//
    |         | date_default_timezone_set('GMT');" but found
    |         | "//date_default_timezone_set('GMT');"
 17 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 17 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 18 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 18 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 19 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 19 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 20 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 20 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 21 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 21 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 22 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 22 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 23 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 23 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 24 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 24 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 25 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 25 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 26 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 27 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 27 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 28 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 28 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 29 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 29 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 30 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 30 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 31 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 31 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 32 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 32 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 33 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 33 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 34 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 34 | ERROR   | Closing brace indented incorrectly; expected 2 spaces, found 5
 37 | ERROR   | No space before comment text; expected "//
    |         | date_default_timezone_set($tz);" but found
    |         | "//date_default_timezone_set($tz);"
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

tramm’s picture

Status: Needs work » Needs review

Fixed the issues noted by Coder Sniffer.

vlad.pavlovic’s picture

Results of manual review:

Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.

Please create a README.txt that follows the guidelines for in-project documentation.

Your code does not seem very well commented, please make sure it's clearly understandable by other developers. Please have a look at the module documentation guidelines and the Doxygen and comment formatting conventions.

If the password you are using is the Google account user password, you should not be showing it in plain-text nor encouraging people to use insecure passwords.

In plugins/FeedsGCalFetcher.inc [37] watchdog messages should use variables for non-static strings.

jamesoakley’s picture

Status: Needs review » Needs work

Changing back to "Needs Work" - see comments in #3

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

Fixed git repository address