Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Mar 2013 at 05:56 UTC
Updated:
24 Jun 2013 at 22:26 UTC
Feeds GCal importer for Feeds module to facilitate importing Google Calendar user's full united feeds instad of single iCal feed. The full feed of feeds seems to be available only through Google API and that was the reason for developing the module/plugin. The module depends on Zend Framework.
The module probably needs improvement to deal a bit better with storing the Google password.
Clone it from git:
git clone --branch master git.drupal.org:sandbox/tramm/1946212.git feeds_gcal
git clone --branch 7.x-1.x git.drupal.org:sandbox/tramm/1946212.git feeds_gcal
Comments
Comment #1
ycshen commentedIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
Source: http://ventral.org/pareview - PAReview.sh online service
Comment #2
tramm commentedFixed the issues noted by Coder Sniffer.
Comment #3
vlad.pavlovic commentedResults of manual review:
Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.
Please create a README.txt that follows the guidelines for in-project documentation.
Your code does not seem very well commented, please make sure it's clearly understandable by other developers. Please have a look at the module documentation guidelines and the Doxygen and comment formatting conventions.
If the password you are using is the Google account user password, you should not be showing it in plain-text nor encouraging people to use insecure passwords.
In plugins/FeedsGCalFetcher.inc [37] watchdog messages should use variables for non-static strings.
Comment #4
jamesoakleyChanging back to "Needs Work" - see comments in #3
Comment #5
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5.0
PA robot commentedFixed git repository address