Closed (won't fix)
Project:
Image Assist
Version:
5.x-2.0-alpha1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Nov 2007 at 15:18 UTC
Updated:
9 Jan 2011 at 07:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
wu_trax commentedComment #2
binford2k commentedYes, this is something that's often tweaked me about this and seeing this bug tonight prompted me to track it down.
The problem actually appears to reside in the tiny mce module (but I have a hack for you). There is a setting for the tiny mce module that allows you to use the theme css. However, it doesn't appear to work right. Therefore, when img_assist loads, it asks tinymce what css to use and it gets the tinymce default css.
I simply disabled the check so it loads all the css files like any other page. A patch is attached, but you don't like patches, just edit img_assist.module and add false to line 1731, like such:
$output .= " if (false && parent.tinyMCE) {\n";
Much sexier output now :-)
Again, this is not a fix, but a hack to make it work. Perhaps now that the devs know where to look, they can make a real fix. (although, to be honest, this page will always look like ass if system.css isn't included anyways.)
Comment #3
sunWhat happens if you merge the contents of
ifandelsein that code, so TinyMCE's and Drupal's stylesheets are loaded concurrently?Comment #4
wu_trax commentedI kind of forgot about this.
Thanks a lot.
Comment #5
mpaler commentedThe bug reported in #2 above persists. I'm using version 5.x-2-alpha1 along with TinyMCE 3 and Wysiwyg.
In my case, when I popup the image assist dialog from tiny tinymce button, no css styles are being embedded properly, not even the default TinyMCE css.
Using my rudimentary javascript debugging skills if I put an alert in the image_assist.module around line 1788 as follows:
The alert msg on the browser says "undefined."
Using the hack in #2, I was at least able to get the drupal css into the form.
Not sure how to fix this as I don't understand the getParam(popups_css) bit.
Thanks,
Mike
Comment #6
sunHm. Did you check the version of this issue?
Comment #7
mpaler commentedI did. The same issue seems to be cropping up in the newer version of the module so I bumped this thread rather than start a new issue...
Mike
Comment #8
sunWell, there are fundamental differences between 1.x and 2.x. Either this issue is reclassified as bug in 2.x, or I'm going to mark this issue won't fix, since I will not waste any more time with 1.x.
Comment #9
mpaler commentedSun, totally understand.
I'll go ahead and reclassify this issue. If that causes any problems, please let me know and I'll start a new one...
Mike
Comment #10
sunThis issue is not going to be fixed anymore.