Closed (fixed)
Project:
Social media
Version:
7.x-1.0-beta13
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Mar 2013 at 13:43 UTC
Updated:
25 May 2017 at 08:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
debo7debo commentedSo I found the problem in the "socialmedia.widgets.inc" file. All the javascripts and images being loaded need to be from the https protocol, not http. This will prevent browsers from displaying message that "not all the content on the site are secure" when being loaded on a secure site. I found the problems in the sections of the file below.
I don't know how to write patches so I changed it manually in my file, so if someone can write a patch for this and submit it that would be great for everyone.
Comment #2
debo7debo commentedStill finding an "addthis" script still using http:// in the source code of a rendered page, but I can't find any more http:// in the socialmedia module files.
Here is the code:
<script src="http://s7.addthis.com/js/250/addthis_widget.js#username=" type="text/javascript"></script>Comment #3
debo7debo commentedOk so I fixed that final piece. Apparently, the widgets generated by setup wizard have to regenerated by another run of the setup wizard. Downside of this is that if you customized placements and restrictions on blocks and other things, the setup wizard resets all of that.
Comment #4
ben.bunk commentedAdding a patch to switch all external paths to protocol relative to prevent http/https mismatch problems.
I have to apply patches with (patch -p1 < file.patch) but you might be able to use git apply.
Comment #5
mukhsim commentedPlease find attached correct patch.
Comment #6
mdawe commentedThis does not appear to be merged into release yet?
Comment #7
dfletcher commentedWould be great if this fix could get rolled into the latest version. Every time this module is updated I have to reapply patch since my client forces visitors to https via htaccess. I usually hear about this after someone applies updates and then opens a bug report with missing social media buttons. Would be fantastic if client didn't have to see this bug again. Is seems pretty simple to remove http: and use CDN style URLs, or am I missing something here?
Comment #8
Exigo commentedSomehow I could not apply correctly any of these patches, but I just manually replaced http:// with https://. I would also need this functionality to work without patching.
Comment #9
junaidpvHere is the rerolled patch for latest dev.
Comment #10
kyletaylored commentedThanks everyone! Rolling this in now, also removing a couple debug statements and unused variables.
Comment #11
kyletaylored commented