Description

Drupal Twitter is a simple-to-use module that allows creation of multiple blocks with Twitter feeds. Each block has independent settings and pulls results from Twitter with the help of public queries or the Twitter REST API. (The OAuth module available at http://drupal.org/project/oauth is required for this.)
The style of the Twitter feed is fully customizable using the drupal-twitter-list.tpl.php template.

Installation

  1. Download and install the module as usual.
  2. Download and install the Oauth module if use of Twitter API is necessary. Go to Administration » Configuration » User interface » Twitter, and configure your access keys there.
  3. Go to Administration » Structure » Blocks, and create a new Twitter block using the “Add twitter block” link.
  4. Configure the block settings with desired Twitter parameters using the on-screen instructions.

Features

  • pulls Twitter feed from one or more Twitter user accounts
  • pulls Twitter search results by hashtag or search term
  • uses public queries and the Twitter API to obtain data
  • cache enabled
  • user avatars with different sizes
  • customizable publish date format including “time ago” format
  • Twitter message styling
  • shows multiple blocks on one page

http://drupal.org/sandbox/psd2html/1949062
http://drupalcode.org/sandbox/psd2html/1949062.git

This module works both with Drupal 6 and Drupal 7

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxpsd2html1949062git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

psd2html’s picture

psd2html commented
Status: Needs work » Needs review

All errors fixed

psd2html’s picture

psd2html commented

Fixes have been made to version 7.x-1.x (default branch).
6.x-1.x fixes coming soon

bechtold’s picture

bechtold commented

Hi psd2html,
first off all I don't see the need of adding Drupal to the module name. I would assume its obvious that its a Drupal module.
I would suggest calling it only twitter block, maybe keep that in mind for future modules.
Then I had a hard time enabling the module via drush. I was expecting to turn drupal_twitter_block on.
Your modules real-/foldername is only drupal_twitter. Thats kind of confusing. I also think thats to generic, drupal_twitter_block includes a bit more of what the module does, thats way better.

Kind of the same with the Menu entries and pages, please call it twitter block.
It might be the case, that a site has more than just one module doing stuff with twitter.
Then it would help to differentiate more.

I just installed, went to the admin page and clicked the wipe avatar cache button.

Fatal error: Call to undefined function image_style_load() in /Users/oskar/workspace/brightsolutions/sandbox/sites/all/modules/custom/drupal_twitter_block/drupal_twitter.module on line 252

Thats what I got :-(

Same error when I click the add twitter block link.
Im happy to review more once the module is working.

When just quickly scanning your code I couldn't see any inline comments.
I'm not sure yet if your code is self explanatory enough, but some comments wouldn't hurt I guess.

Cheers,
bechtold

psd2html’s picture

psd2html commented

I just installed, went to the admin page and clicked the wipe avatar cache button.

Fatal error: Call to undefined function image_style_load() in /Users/oskar/workspace/brightsolutions/sandbox/sites/all/modules/custom/drupal_twitter_block/drupal_twitter.module on line 252

This is because there was no check for module "image", which is used for avatars.

*Fixed.

Now the functionality of avatars available only when the module "image" is turned on.

I would assume its obvious that its a Drupal module.
I would suggest calling it only twitter block, maybe keep that in mind for future modules.

"twitter block" and "twitter" - already exists.

Our module - is a combination of features both of them. More opportunities in the presence of OAuth, and the advantage of easy and quick setup using RSS, when additional features OAuth is required. Since both names are busy, the first thing that comes to mind - "twitter_for_drupal" or "twitter_feed". First - attractive in terms of "SEO".

When just quickly scanning your code I couldn't see any inline comments.
I'm not sure yet if your code is self explanatory enough, but some comments wouldn't hurt I guess.

We have tried to comment on the most complex parts of the code. The purpose of most methods and functions has been described. In the future, we will try to give more detailed comments to our code.

Cheers,
psd2html

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

I can see how this module doesn't do exactly the same as the existing Twitter module, but is it sufficiently distinct that it warrants creating a new module as opposed to adding features to the existing module?

Just for reference, the path to git for this module is http://git.drupal.org/sandbox/psd2html/1949062.git, not the http://drupalcode.org/sandbox/psd2html/1949062.git that is in the issue summary for this issue.

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs review » Postponed (maintainer needs more info)
psd2html’s picture

psd2html commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

This sounds like a feature that should live in the existing twitter project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the twitter issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

PA robot’s picture

PA robot commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

ollakalla’s picture

ollakalla commented

i have add the twitter block to the website
but i use Panel , and i want to show this twitter block in the Panel of the home page
thx

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

@ollakalla - I'm not sure what help you're looking for, but you won't find it here.

This is an issue queue for people who want permission to launch a new Drupal module, and need their code checking because it's their first contributed module. This user wanted to start a new module called "twitter block", and they were asked how it differed from other modules that already do something similar. They never answered, so their request was turned down, for now.

If you've set up your Twitter block using a contributed module, I'd suggest finding the issue queue for that module and asking your question there.

If you've done it from scratch, just using Drupal core components, you could ask in the general "post-installation" Drupal forum.

If your question is specific to Panels, you could ask in the Panels issue queue.

I thought I'd reply here, though, because you may not have been aware that nobody would see your question here.