It is great that the installer notices that you do not have a 'files' folder... However best practices suggest 'sites/default/files' as a prime choice. Is this really something that should be an installation blocker? Is there reason we don't check the entire sites tree for a writable 'files' folder as well as /files?

CommentFileSizeAuthor
#4 195033.patch573 bytesdopry
#3 195033.patch573 bytesdopry

Comments

kbahey’s picture

kbahey commented
Status: Active » Closed (duplicate)

I agree we should move the default 'files' to 'sites/default/files', as per best practices.

Since there is already an issue on this, #194860, I am marking this as a duplicate.

dopry’s picture

dopry commented
Status: Closed (duplicate) » Active

This is not a duplicate. This issue is specifically an unnecessary installer requirement. #194860 is about making the example.com/files map to sites/*/files. Not in my interest.

dopry’s picture

dopry commented
StatusFileSize
new 195033.patch573 bytes

here is patch that uses conf_path() in file_directory_path.

dopry’s picture

dopry commented
StatusFileSize
new 195033.patch573 bytes

here is patch that uses conf_path() in file_directory_path.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

Is this really something that should be an installation blocker?

http://drupal.org/node/191310

catch’s picture

catch
he/him
Primary language English
commented

Requirement was added here: http://drupal.org/node/191310

This is a patch.

robloach’s picture

robloach
he/him
commented

Another similar issue made to move the files directory to sites/*/files.

catch’s picture

catch
he/him
Primary language English
commented

edit: ignore me, the other issue was the one you linked to :|

moshe weitzman’s picture

moshe weitzman commented
Version: 6.0-beta3 » 7.x-dev
lilou’s picture

lilou commented
Status: Needs review » Closed (fixed)

Already committed.