Add the (foward) slash to the list of character settings

I agree that the admin should have control of this.

The trick is that all strings are passed through the same cleaning function, so pathauto has to be smart about whether or not it strips out the forward slash when it is dealing with termpath or bookpath etc.

I second this.

Removal of the slashes results in undesirable "glueing" in URLs. It would be much appreciated, if the slashes would be replaced by another character, instead of simply being removed.

Assigning to myself to indicate I want it done for 5.x-2.1.

+1

Sorry for leaving my name on this. I re-prioritized and don't have time for this now.

Anyone working on this? I hate the forward slash being removed, would love the option to choose to the regular separator instead.

I've put together a trivial patch that fixes this for the 2.2 release. Hopefully that pokes this enough to get this ticket closed in some manner :-)

The problem with this approach is that it doesn't work for people who use termpath nor catpath nor termalias nor bookpath (etc.)

Thanks for the idea, though!

This is what I changed on lines 235 and 236 so that my taxonomy paths looked good when there was a slash in the term names. You could do something similar.

$values[$label .'path'] = $catpath .'/'. check_plain(preg_replace('/\//', '', $category->name));
$values[$label .'path-raw'] = $catpath_raw .'/'. preg_replace('/\//', '', $category->name);

@abv - Works great for termpath/catpath - but not for bookpath etc.

It'd be a great feature for Drupal 6 as well.

Here's a new patch for 6.x that adds in the ability to replace forward slashes. In my (limited) testing, it handles the special cases for menu and taxonomy paths (my changes just piggyback on the code that already skips replacement of slashes in those cases). Please test and let's get this into the next release...

I agree, this is important functionality.

Applying the following to Path Auto 6.x-2.x-dev fails:

patch < pathauto-slash-replacements.patch
patching file pathauto.inc
Hunk #1 succeeded at 192 with fuzz 2 (offset 51 lines).
Hunk #2 FAILED at 204.
Hunk #3 succeeded at 468 (offset -3 lines).
Hunk #4 succeeded at 553 (offset 51 lines).
1 out of 4 hunks FAILED -- saving rejects to file pathauto.inc.rej

Joshua's patch was not made based on current HEAD version of pathauto.inc. I've fixed that.
Also fixed another bug: Joshua deleted the original slash removing code.
I mean this one:

  // If something is already urlsafe then don't remove slashes
  if ($clean_slash) {
    $output = str_replace('/', '', $output);
  }

However with his patch if the function gets $clean_slash=TRUE parameter and the punctuation rule for slashes is set by the user as action=2 (no action, do not replace), then slashes will be kept in the string, which is wrong (since the function parameter $clean_slash has to be favoured over user's setting for slash handling).

I've fixed this one too (by putting back the original slash replacer code) and attached revised patch. Of course the fix could have been done differently too, but this seemed to be the better choice.

I've changed the status to "reviewed and tested".
I'm not sure whether a single review+test is sufficient for this status change, but unfortunately this patch did not get much attention from anyone else in recent months and I don't think we should wait another 3-4 months til someone else tests it too ...

I don't think that $clean_slash should have precedence. $clean_slash is set to FALSE for e.g. menupath or menupath-raw. But if I *want* the slash to be replaced, it *should* be replaced. Otherwise the patch gives not really any control to most situations...

bump.

Any updates on this being included in the next release? Or someone else testing the patch?

+1

This works with custom tokens too; add "path" in the token name if you want to keep your forward slashes.

Is there a solution to this issue yet?

Subscribe

Has menutrails been fixed yet?

I'm having similar issues with the Hierarchical Select module (6.x-3.x-dev), Pathauto (6.x-1.1), and Token (6.x-1.12).

Using token: [save-lineage-termpath-raw:vid] I get a hyphen separating terms: parent-child

So, in template.php I set: variable_set('hs_taxonomy_separator', '/'); It is joining the terms together without the / (slash): parentchild NOT parent/child

I've also tried hacking the hs_taxonomy.module and setting: $separator = '/'; with same results.

How do I put the slash between the terms? It seems Pathauto keeps dropping it.

The solution I found for #29 was on line 452:

if (drupal_substr($full->tokens[$key], -4, 4) === 'path' || drupal_substr($full->tokens[$key], -8, 8) === 'path-raw' || drupal_substr($full->tokens[$key], -5, 5) === 'alias') {

if (strpos($full->tokens[$key], 'path') !== FALSE || strpos($full->tokens[$key], 'alias') !== FALSE) {

I'm not sure if there was a reason drupal_substr was being used, when strpos seemed to accomplish the task quite nicely.... drupal_substr only looks at the ends of the strings, but we needed to find "path" wherever it was--strpos allowed for a trailing :vid.

Hi all. I updated all at 20/122009 but can't found a method to convert some as:
Ex: "bag/hat" that now is converted to "baghat": bad for SEO.. I want 2 words separated by "-".
I'm not found punctuation settings option for exchange slash "/" from node title.
I simply want to splint words in resulting url alias.
Thanks 4 info

So does anyone know how to remove the /slash from terms titles without affecting term paths?

@ManyNancy: That is now how the term path tokens work now in the latest code.

Unless we can get a clear definition of what is the problem and how to fix it (which I can't get from reading all this issue's replies), plus a detailed list of how to reproduce the problem in order to write a test to make sure it doesn't get broken again, I don't think we'll be able to get this fixed in the next release.

@Dave Reid: My understanding of the issue, Dave, (or at least my interest in it) is that if you have a node title or a taxonomy term with a slash in it (e.g. "Love/Hate"), Pathauto will leave that slash in path aliases based on it, giving the false appearance of a directory structure (e.g. blog/categories/love/hate). The desirable behavior, of course, would be to be able to define how a forward slash is handled the same way we do other punctuation and special characters—by specifying via the UI whether and with what to replace it (e.g. with a dash, so that the afore-mentioned example would result in an alias of blog/categories/love-hate). Does that clear things up at all?

@TravisCarden: Ah, we actually fixed that with another issue for removing slashes on an individual taxonomy term. :)

Is there anything else to this or should I just mark it as fixed then?

@Dave Reid, is that in 6.1.x or 6.2.x or both? Should I use the dev version if I want this feature?

Thanks.

@ManyNancy: It's currently in all branches of the module. If you're going to be using a D6 version, I'd recommend using the 6.x-1.x-dev release.

@Dave Reid: Thanks, Dave. Did the fix you refer to above (#36) also treat node titles containing slashes? In order to mark this issue as fixed, I think we need to make sure we've handled every class of automated aliases: terms, nodes, and users.

@TravisCarden: Actually now that I went and checked this more I realized we're now running taxonomy terms through pahtauto_cleanstring() but that we're still removing the forward slash. I'm working on a solution for 6.x-1.x and 7.x-1.x to get this fixed once and for all, plus tests to back it up.

Marked #728276: Add slash to array of punctuation values as a duplicate of this issue.

I'm ok with node title slashes being removed. My problem was that term titles did not have slashes removed.

Hello Bobzillaforever

Thanks a lot for your solutions, I apply and works like a charm.

I expend like 8 hours research in hierarchical select until I found your solution.

Thanks so much.

Please apply this path.

enzo

subscribing

subscribing

subscribing

I might be missing something crucial here but can I take step back and suggest that we simply be given control over whether or whether or not to strip out '/' characters in tokens per se.

Why can't we have the same control over these as we do with other characters such as '&' etc. ?

Personally, I REALLY need to be able to make up tokens which are psuedo URLs like this...

...home/child-1/grandchild-1/great-grandchild-1

but I need to do it in a SINGLE TOKEN because I cannot pre-determine how deep the tree is going to be.

What I really do not want to see this reduced to...

...home/child-1grandchild-1great-grandchild-1

or indeed anything else replacing the '/'

Any offers of advice on how I might achieve this given that pathauto insists on stripping the slashes out of my lovingly constructed tokens!

Thanks

@SirClickALot: Name your token with a '-path' or '-url' suffix and it will be treated like an URL and not have slashes removed.

Due to changes made previously, this really was a simple patch! Tested locally on all three branches.
http://drupal.org/cvs?commit=404554
http://drupal.org/cvs?commit=404556
http://drupal.org/cvs?commit=404564

[stupid question removed] :-P

Yep it was committed to 7.x-1.x, 6.x-2.x, and 6.x-1.x. It would be super double-plus awesome if you could help test them today.