Closed (cannot reproduce)
Project:
Forward
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Nov 2007 at 02:44 UTC
Updated:
1 Feb 2012 at 21:44 UTC
Hello,
At the moment, the module always always displays the forward link for comments.
The code is:
function forward_link($type, $node=0, $main=0) {
if (user_access('access forward') && (variable_get('forward_form_type', 'link') == "link") && variable_get('forward_display_'. $node->type, '1')){
Now... for comments, $node->type is empty. So, effectively, the module checks the variable 'forward_display_', which is empty, and therefore '1' is taken as a default.
Ideally, the module should have a config option for comments.
Unless I am missing something, which is very possible.
It's not urgent for me, because I just manually added an entry in the "variable" table: 'forward_display_'.
But still...
Merc.
Comments
Comment #1
seanrLook at line 561 through 599:
In particular, line 565 which should read as follows:
If you do not see that, please update your copy. That variable gets set in admin/settings/forward.
Comment #2
seanrIs it still doling this? I think I fixed this in response to another issue (gotta hate duplicates, LOL).
Comment #3
mercmobily commentedHi,
Sorry about this. I have bugs that are open forever as well...
Will investigate it and let you know!
Merc.
Comment #4
john.oltman commented