Cue field uses a field collection to provide jump links for video or audio. Currently jPlayer (rendered through audiofield) and jw_player are supported. It was written as part of the chapter integration of Shared Content

The documentation can be found on the projects page (http://drupal.org/sandbox/corvus_ch/1956942) as well as in the README file.

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/corvus_ch/1956942.git

Comments

SamChez’s picture

SamChez commented
Status: Active » Needs work

For starters there does not seem to be a default branch click here for information on how to set one. Also remove the ./cue_field.info file, drupal packages that automatically. Code sniffer also returned a couple problems:

FILE: /var/www/drupal-7-pareview/pareview_temp/cue_field.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
136 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
405 | WARNING | Line exceeds 80 characters; contains 118 characters
--------------------------------------------------------------------------------
corvus_ch’s picture

corvus_ch commented
Status: Needs work » Needs review

Thanks for the review.

The default branch is set now and I added the missing dot.

As of the warning for line 405. This line contains an URL. I do not file comfortable to add a line break inside an URL nor to us an URL shortener. If someone have a could idea how to deal best with such a solution, I would appreciate sharing.

corvus_ch’s picture

corvus_ch commented

Also remove the ./cue_field.info file, drupal packages that automatically

I guess the suggestion wasn't to actually remove the .info file but to remove the version info in it which I have done.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

chason’s picture

chason commented

@corvus_ch, it looks like there is one error being generated by code sniffer - http://ventral.org/pareview/httpgitdrupalorgsandboxcorvusch1956942git

corvus_ch’s picture

corvus_ch commented

Actually it is a warning and as I already pointed out in comment #2 it is due to an URL. Suggestion how to do this better are highly appreciated.

corvus_ch’s picture

corvus_ch commented

I have replaced the url with textual reference.

For in my opinion this is a false positive, I have filed an issue to coder (#1963666: False positive on commented URLs).

chason’s picture

chason commented

You could concatenate the URL string into a structure such as the following to get around the error:

$url = 'http://www.example.com/';
$url .= 'directory/example-file.html';
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Title: [d7] Cue Field » [D7] Cue Field
Status: Needs review » Reviewed & tested by the community

Code looks great, thanks!

----
Top Shelf Modules - Enterprise modules from the community for the community.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

You should probably remove cue_field_update_7000() unless you still need it. By using administer site configuration as the menu access permission, you're only allowing admins to make use of this field. Could it be a separate permission instead? That way the admin could allow any role to make use of your module.

In cue_field_add_cue_field_form_submit() don't use a drupal_goto() - instead just redirect the user with $form_state['redirect']. Using a goto actually stops drupal execution at that point and can cause weird side effects.

The module still looks good, and thanks for including a test!

Thanks for your contribution, corvus_ch!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.