[D7] Google Translate Widget

Move code into 7.x-1.x branch and put in the topic link to repository for non-maintainers.

Automated review

http://ventral.org/pareview/httpgitdrupalorgsandboxmatters1956976git All right!

Manual review

1. google_translate_widget_widget_block_info() should be named google_translate_widget_block_info() . The same for the google_translate_widget_widget_install() function.

2.

'#description' => t(
        'If you wish to control the translation of your content on the site, please register at this !address and enter the resulting hash code in this field.',
       array('!address' => '<a href="https://translate.google.com/manager/website/">address</a>')
       ),

This should be like this (see format_string() function description)

'#description' => t(
        'If you wish to control the translation of your content on the site, please register at this <a href="https://translate.google.com/manager/website/">address</a> and enter the resulting hash code in this field.'
       ),

3. In google_translate_widget.module on line 102 you can use $language_array instead of calling function google_translate_widget_languages().

PS: FYI, when you fix all these issues you have to change issue status to 'needds review'.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review: Passed!

Manual Review:
I know that the module is short and sweet, but you should still have some inline comments, I haven't found any.

In google_translate_widget_block_view($delta = ''), you add javascript (both a file and inline code) using HTML.
Perhaps you should use drupal_add_js.

After implementing the module it seems to work fairly well however there are some minor issues which seem to be very specific

• For example in snapshot1 clicking on the drop-down box occasionally likes to shove the page downward. This can be fixed by not moving the page and re-clicking the box however this could potentially effect the user-experience.
• Another bug I found, a very minor one at that, is that when placed in the footer of the Bartrik theme with display mode set to "Dropdown only" the text in the box "disappears" I say that because in actuality it merely inherits the colour white and can be fixed by tweaking the css.

Otherwise a pretty useful module, really easy to use, for the most part it's just plug and play.

http://drupal.org/project/gtranslate

This sounds like a feature that should live in the existing gtranslate project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the gtranslate issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Just checked and it does indeed look like gtranslate has an enterprise version.

I get the following from the automatic review:

FILE: /var/www/drupal-7-pareview/pareview_temp/google_translate_widget.module
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
124 | WARNING | Do not pass empty strings to t()
--------------------------------------------------------------------------------

Also, the variable set by your module is 'translate_widget', but since your module is called google_translate_widget the variable should be named 'google_translate_widget' to avoid clashes.

It seems that Google Translate provides very similar functionality. Could you describe how your module differs? Your version is obviously D7, if you can take over that obsolete module then your code can go into a 7.x-1.x branch of that module and be released.

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

----
Top Shelf Modules - Enterprise modules from the community for the community.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Added fourth review