Closed (duplicate)
Project:
Panels Tabs
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
27 Nov 2007 at 17:01 UTC
Updated:
5 Jul 2008 at 17:46 UTC
I'm not sure why its not working, but it doesn't seem to be. On a potentially related issue, I'm getting:
array_merge_recursive(): recursion detected in [dir]/includes/common.inc on line 1674 with devel on. It has to do with the fact that the following code is being called twice.
if ($settings['filling_tabs'] > 0) {
drupal_add_js(drupal_get_path('module', 'panels_tabs') .'/panels_tabs.js');
drupal_add_js(
array(
'panels_tabs' => array('filling_tabs' => array( $id => $settings['filling_tabs']))
), 'setting');
}
Comments
Comment #1
najibx commentedI don't find this error with panels 5.x-2.0-alpha14 Last updated: November 22, 2007 - 06:55 and panels_tabs-5.x-1.2 2007-Nov-15. ( not the panels_tabs-5.x-1.x-dev)
How do you find this error with devel on, anyway? On the Recent log entries? I don't see any errors.
I just could not see the "panels_tabs" option, only sees regular "Provide Menu as Tab" which is nothing related to this module is, isn't?
So which latest panels module is working ? It does says..... Dependencies Panels 2 alpha 11 or better ...
Comment #2
wim leersI can't reproduce that either.
najibx: look in the "Layout" tab, there you can choose the style.
Comment #3
wim leersComment #4
wim leersComment #5
wim leersAssuming this doesn't need fixing, since the lack of replies.
Comment #6
geshan commentedIt needs fixing. See another issue here:
http://drupal.org/node/199786
Comment #7
SolomonGifford commentedSorry, I thought I had subscribed to this issue and hadn't seen any responses in my email...
I have gone a different route, so I'm not using the panels_tabs anymore. I'll post an update if I attempt again.
Comment #8
michelleJust for confirmation, the tabs work fine with panels beta 1.
Michelle
Comment #9
wim leersYep, also works fine here in beta 1. The version for Panels 2 beta 1 -- version 1.3 -- also has several other improvements. So please upgrade to those versions.
Comment #10
najibx commentedOK. got it running.
I was wondering the best practices to modify the tabs style.
I change the tabs.css located in the modules/jstools/tabs
how can I have multiple tabs style and put the tabs.css in theme folder. must override in template.php?
tq
Comment #11
wim leersPlease start a new issue for a new question next time!
You should not change tabs.css. You should override the styles based on the IDs that Panels provides (or the ones that you enter, because you can enter a CSS id for any Panel), which allows you to target each Panel specifically.
Comment #12
stevryn commentedi just installed Panels 2 beta 1. I am still seeing this error when trying to view my panel page:
warning: array_merge_recursive() [function.array-merge-recursive]: recursion detected in /home/ndpweb/xampp/htdocs/drupal_main/includes/common.inc on line 1667.
Comment #13
stevryn commentedWait...could this be because you have content laid out in a 2 column panel?? When I deleted my content and placed it in a SINGLE column it doesnt appear to have that error anymore.
Comment #14
wim leersHm. It doesn't make sense to put it in a 2-column lay-out, because Tabs panel style works on each pane of *one* panel. But I guess that needs much better documentation... Marking this issue as such. Will do this as soon as I have the time.
Comment #15
najibx commentedWim Leers,
Sorry about that. Will not do that again :P
Thank you for the tips. I overlook that.
Comment #16
wim leersComment #17
wim leersNo longer necessary, fixed: http://drupal.org/node/207486.