Closed (fixed)
Project:
Panels Tabs
Version:
5.x-1.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Jan 2008 at 02:28 UTC
Updated:
23 Jul 2008 at 10:56 UTC
Jump to comment: Most recent file
I just started playing with panels 2.x development module with the tabs panel style module. I was able to setup my mini-panels with tabs but I ran into this warning on most pages with or without the tabbed minipanel:
warning: array_merge_recursive() [function.array-merge-recursive]: recursion detected in includes/common.inc on line 1679.
After refreshing the page again, the warning goes away temporarily. When I changed the layout setting to something else, other than Tabs, I don't run into this warning. I don't know where to begin to figure the error out.
| Comment | File | Size | Author |
|---|---|---|---|
| #26 | patch_panels-tabs.diff | 801 bytes | chl-dev |
Comments
Comment #1
wim leersWhat lay-out are you using for your mini panel? You should use a single column layout. I know that I need to document this better.
Comment #2
jmai commentedI'm using the single column layout with four blocks in the minipanel
Comment #3
wim leersHm. Which exact versions of Panels 2 and Tabs panel style are you using? And which Drupal version?
Comment #4
jmai commentedI'm using Panels 2 Beta 1 December 31st release and Tabs Panel Style 1.x Jan 03 with Drupal 5.5
I was looking at the issue #195766, and it seems to be similiar if not exact problem.
line #1679 is from the lastest common.inc from the Dec 27 dev of Drupal 5 instead of the original file packaged with D5.5
Comment #5
wim leersHm could you send me the login details for your site so I can see it for myself? And if you want to get it solved, you may want to give me temporary FTP access as well.
Comment #6
jmai commentedHow would i get the log details of my site so that i can send it to you? I will email you the access to my site directly. BTW, where would u need ftp access to?
Comment #7
wim leersUse my contact tab: http://drupal.org/user/99777/contact. FTP access would be necessary, yes.
Comment #8
wim leersComment #9
wim leersThe reason is that I'm using the CSS id of a panel as a unique identifier to pass through the settings for each panel that uses the Tabs style to Javascript. However, Panels beta 1 does not yet ensure unique ids. This is fixed since yesterday in CVS (I had reported it). Please upgrade to latest version in the DRUPAL-5--2 branch of Panels to verify that that fixes it.
Comment #10
jmai commentedGreat News, it worked so far with the CVS version of panels 2.x labeled 5--2. No warnings. Thanks a lot Wim Leers
Comment #11
wim leersI didn't change anything...
Comment #12
jmai commentedoops, I spoke too soon. It comes up less frequently now than before.
Comment #13
jmai commentedSeems like when I have 2 or more minipanels w/ the tabs layout setting I get this error. These minipanels don't have to be on the same page necessarily, but the errors are random.
Comment #14
patchak commentedI also have the same errors on nearly each page load on my site. I'm using panels beta 2. Is this the latest version I should use??
Also using tabs style 5-x-1.3
patchak
Comment #15
wim leersWhich layout are your Mini panels using?
Comment #16
patchak commentedhey there, I'm using the tabs style, you can see it on geekomatik.com
patchak
Comment #17
wim leersStyle != layout…
Layouts: single, 2-column, 3-column, etc.
Styles: list, rounded corners, tabs, etc.
So, which layout are you using? :)
Comment #18
patchak commentedOh sorry, single column
Patchak
Comment #19
patchak commentedHey there Wim.
I think this error does not really have any consequences on my site, but still it,s annoying for the visitors to always seems an error like this. Is there any way to hide this error or to sent it to the watchdog only??
I thought about only display it when userID 1 is logged in, that would be cool, any idea how to do that?
Thanks
Comment #20
patchak commentedHumm I just found the site reporting options in drupal 5 sorry about this post...
Comment #21
wim leersIs the line number of the error still the same? Are you using the latest versions of Drupal, panels 2 and panels_tabs?
Comment #22
Debugger_01 commentedI have same error message
warning: array_merge_recursive() [function.array-merge-recursive]: recursion detected in C:\www\includes\common.inc on line 1679.
when I go on
http://server/admin/panels/panel-mini
Panels "5.x-2.0-beta2"
panels tabs "5.x-1.4"
Drupal 5.7
Comment #23
ugerhard commentedI'm got this error, too, but only on certain pages that contain more than one minipanel with the Panels tabs style. I did some digging around and now I'm not getting the error anymore after I did one thing: I explicitely set the "Style settings" for one of the Mini panels, which I had not explicitely set before.
So I have a hunch that the problem is in theme_panels_tabs_style_render_panel() in panels_tabs.module:
When "Style settings" for a specific panel have not been explicitely set, the parameter $settings seems to be empty. $display->css_id there is empty, too.
So if there is more than one panel on a page where both values are empty, the array_merge_recursive in drupal_add_js() will choke on the resulting arrays that are given to drupal_add_js() in theme_panels_tabs_style_render_panel().
Comment #24
ugerhard commentedP.S. I use Tabs panel style 5.x-1.4 and the latest Panels 5.x-2.x-dev
Comment #25
rup3rt commentedSubscribing
Comment #26
chl-dev commentedHello,
I came accross something similar and crawled to the function 'panels_render_panel' and it seems that 'panels_get_panel_style_and_settings' do not always send something useful.
Unfortunately, time is missing right now so I made this ugly patch, in case it helps (it seems to stop the errors on my site)
As you can see, I just don't call drupal_add_js when something is missing (and from my experiments, I got $display->css_id = "" simultaneously with $settings['filling_tabs'] = NULL)
Hope it can give someone some hints :-/
Comment #27
WorldFallz commentedTested patch in #26. Applies fine and fixed the problem for me. No other problems so far.
Comment #28
WorldFallz commentedupdating status.
Comment #29
bsarchive commentedI was having the same problem on most pages, whether they had panels or not!
This has fixed it -- thanks!
Comment #30
wim leersFinally reproduced. This happens when you're using this style on a layout with multiple panels, in which case the JS settings are added multiple times.
This is an easy fix, *but* there's a bug in Panels that prevents a proper
$display->css_idfrom being generated, which makes the fix fail… Working in a patch for Panels, but I haven't tracked down the exact cause yet!Comment #31
wim leersFixed!
Depends on http://drupal.org/node/278861 getting committed though.
Comment #32
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.