The page node/%/questions, when having some categories, doesn't allow to sort them. I can move categories around all I want or change weight directly, it still would be reset to 1 when saving.

I find out that the line 634 of quiz.admin.inc is responsible for this behaviour.
When I comment out this line:
//$existing['weight'] = 1;
weights are saving correctly.

So the question is, should this line be commented out or is there some meaning to it which I don't see?

CommentFileSizeAuthor
#1 1958224.patch621 bytesvalthebald

Comments

valthebald’s picture

Title: node/%/questions category sorting » [PATCH]node/%/questions category sorting
Version: 7.x-4.0-beta1 » 7.x-4.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new621 bytes

I have added check for emptyness of $existing['weight'], just in case

sivaji_ganesh_jojodae’s picture

Status: Needs review » Fixed

Thanks fix committed to both 7.x and 8.x branches.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 7407a46 on 7.x-4.x, 7.x-5.x by sivaji:
    Issue #1958224 by valthebald | graker: [PATCH]node/%/questions category...

  • Commit 7407a46 on 7.x-4.x, 7.x-5.x, quiz-pages by sivaji:
    Issue #1958224 by valthebald | graker: [PATCH]node/%/questions category...

  • Commit 7407a46 on 7.x-4.x, 7.x-5.x, quiz-pages, 2269219 by sivaji:
    Issue #1958224 by valthebald | graker: [PATCH]node/%/questions category...

  • Commit 7407a46 on 7.x-4.x, 7.x-5.x, 2269219 by sivaji:
    Issue #1958224 by valthebald | graker: [PATCH]node/%/questions category...