Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2013 at 17:35 UTC
Updated:
12 Aug 2013 at 19:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxaelkin1959040git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
newsec commentedFixed http://ventral.org/pareview errors
Comment #3
blazas commentedHi,
your git link at issue summary is incorrect - correct link is http://git.drupal.org/sandbox/aelkin/1959040.git
Your code seems ok ;)
Comment #4
newsec commentedHi! Thank you for reply, I corrected link.
Comment #5
teyser commentedHi Aelkin,
Could you please confirm whether my understanding of your project is correct or not.
Please find the attached image.
Just reviewed your module, As per your project description, even if we are having many url alias for each taxonomy, it takes the lats url alias path only.
But even though if I hit the existing url alias also its working fine.
Could you please explain more about your module to me.
Sorry for my poor english.
Thanks&Regards,
-Raj.
Comment #6
chetan-singhal commentedHi @aelkin
I have found few issue relative coding
line no-104 => There is no require to break statement
line no-27 => use $form_state['values'] instead of $_POST
Comment #7
newsec commentedHi, Raj! The main idea: if you want to change taxonomy name, but don't want change the alias - set checkbox.
Comment #8
newsec commentedHi, cpsinghal
Thanks for review! My comments:
line 104 break - I need this for future cases.
line 27 - there is no $form_state['values'] set at that moment. There is $form_state['post'], but if you see on form.inc line #97:
$form_state['post'] = $_POST;
Comment #9
newsec commentedComment #10
kscheirerSeems good, thanks!
----
Top Shelf Modules - Enterprise modules from the community for the community.
Comment #11
newsec commentedThank you, Karl!
Comment #12
newsec commentedIs there anything else I could be doing to go out of sandbox?
Comment #13
kscheirerNo further action is required, but the best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://ventral.org is not enough.
----
Top Shelf Modules - Enterprise modules from the community for the community.
Comment #14
kscheirerI kinda thought Taxonomy would do this out of the box - but you're right it's not present. The module looks useful and the code passes ventral.org cleanly.
Thanks for your contribution, aelkin!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #15.0
(not verified) commentedupdate git link