This module allows to have different than name taxonomy url alias.
It simple save last taxonomy url if checked on term edit form.
Link - http://drupal.org/sandbox/aelkin/1959040
Git - http://git.drupal.org/sandbox/aelkin/1959040.git

Comments

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxaelkin1959040git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

newsec’s picture

Status: Needs work » Needs review
blazas’s picture

Hi,

your git link at issue summary is incorrect - correct link is http://git.drupal.org/sandbox/aelkin/1959040.git

Your code seems ok ;)

newsec’s picture

Hi! Thank you for reply, I corrected link.

teyser’s picture

StatusFileSize
new31.2 KB
new8.88 KB
new6.39 KB

Hi Aelkin,

Could you please confirm whether my understanding of your project is correct or not.

Please find the attached image.

Just reviewed your module, As per your project description, even if we are having many url alias for each taxonomy, it takes the lats url alias path only.

But even though if I hit the existing url alias also its working fine.

Could you please explain more about your module to me.

Sorry for my poor english.

Thanks&Regards,
-Raj.

chetan-singhal’s picture

Status: Needs review » Needs work

Hi @aelkin

I have found few issue relative coding
line no-104 => There is no require to break statement
line no-27 => use $form_state['values'] instead of $_POST

newsec’s picture

Hi, Raj! The main idea: if you want to change taxonomy name, but don't want change the alias - set checkbox.

newsec’s picture

Hi, cpsinghal

Thanks for review! My comments:
line 104 break - I need this for future cases.
line 27 - there is no $form_state['values'] set at that moment. There is $form_state['post'], but if you see on form.inc line #97:
$form_state['post'] = $_POST;

newsec’s picture

Status: Needs work » Needs review
kscheirer’s picture

Status: Needs review » Reviewed & tested by the community

Seems good, thanks!

----
Top Shelf Modules - Enterprise modules from the community for the community.

newsec’s picture

Thank you, Karl!

newsec’s picture

Is there anything else I could be doing to go out of sandbox?

kscheirer’s picture

No further action is required, but the best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://ventral.org is not enough.

----
Top Shelf Modules - Enterprise modules from the community for the community.

kscheirer’s picture

Status: Reviewed & tested by the community » Fixed

I kinda thought Taxonomy would do this out of the box - but you're right it's not present. The module looks useful and the code passes ventral.org cleanly.

Thanks for your contribution, aelkin!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

update git link