[D7] Admin Users

After a thorough review the module looks quite useful and I see a lot of potential in it. A big issue for starters is as the admin of the site I probably shouldn't be given the ability to block myself (the sole administrator). Granted you have a confirmation screen but sometimes that's not enough, possibly add an error message that says something along the lines of "You cannot block the sole remaining administrator." Another problem is when you go to filter your users you break the overlay. This can be fixed by logging out or using the breadcrumbs to go back to the home page.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

serm, nice module
I think we need to add a rule that excludes only the current user not the uid == 1.
Additionally, you should add the text with no result.
Also you must fix overlay. I think it's can be fixed by setting Use AJAX in Yes.

Hi serm,

Great module. I have done automated and manual review of your module :

• Automated review
  http://ventral.org/pareview/httpgitdrupalorgsandboxserm1959266git
  No errors.

• Results of my manual review

  1) Why not adding default action provided by the core for the field "Bulk operations" :
  Modify user roles (user_roles_action)
  Send e-mail (system_send_email_action)

  2) I think You could expose operator for the fields "node count" and "comment count" by default, or if you don't want, juste a description on these fields to explain wich operator is used by default (actually "Is equal to").

  3) You could add more lines on your README.txt :
  -- REQUIREMENTS --

  * Views Bulk Operations

  -- CONFIGURATION --

  * Access administer users in Administration » People » Administration users :
  * Modify the VBO if you want to add actions in Structure » Views » Administration Users (User)

  -- CONTACT --

  Current maintainers :
  * "Your name, login and your drupal page : http://drupal.org/user/2062438"

Hi,
Great module ! Thanks !
Here is the result of my review :

- The css will impact all the views present in the same page as your form. I suggest to me more precise in the css celectors, adding the view name class for example...

- admin_users.views_default.inc needs to allow localisation by makig use of t() function for all strings that will need to be translated.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
i reviewd it again, and i have only one suggestion :
As the module makes use of comments, and because the Core Comment module is not required, i think we should add it as a dependency.

Will RTBC immediately after this as i don't see any other point :)

Thanks

it looks great !

Possible Duplication

It seems that Administration Views provides very similar functionality. Could you describe how your module differs?

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

If that fails for whatever reason please get back to us and set this back to "needs review".

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Implementing a hook_help(), adding options or admin configuration, or other simple hooks can help you get around this limitation. Simpletests are always welcome too!

----
Top Shelf Modules - Crafted, Curated, Contributed.

the last commit deletes a space in t('Update options Operation'),
but we still have a space in the label
$handler->display->display_options['fields']['views_bulk_operations']['label'] = 'Update options Operation ';
we need to have the same string so that the translation can be taken into account

it looks good to me
Thanks

Thanks for the additional simpletests, those look really nice.

Thanks for your contribution, serm!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.