Document theme requirements

Can you post a screenshot or a quick video of what happens?

It should work well with all Drupal core themes.

It does work with a few other themes I tested.
I'm now testing the new Omega theme since it is used a lot.
Everything works except for the body field in full node view with CKEditor installed.
(http://drupal.org/node/1955858#comment-7260310).

Still an interesting question, what does a theme need to make edit work (documentation?).

A theme simply needs to not hack core.

In the README, there's already a FAQ entry for "Edit breaks my node titles!", which is theme-related. Any further guidelines will only become available as we get more experience and learn about the crazy things some themes do and find solutions/work-arounds for those.

I somehow managed to read over the important bit here: "clicking on "Quick edit" only makes the screen semi-white, but no edit region appears, neither for raw fields nor text area".

That sounds like you're either overriding the output of each field (theme_field()?) or are using Display Suite/Views. Please let us know.

I don't want to hijack this issue, but it may be related.

Wim could you have a look at this issue ?
And maybe give another hint, where to look?

Commented.

I'm seeing the same behaviour, with a js error of "Uncaught TypeError: Cannot read property 'element' of undefined" in create-editonly.js on line 341.

Thanks Wim, additional info has been added.
And splatio has narrowed down the problem a bit, asking for your thoughts.

#7: Any chance you're using jQuery Update?

Why yes! I'm using 1.7 on the frontend.

jQuery 1.7? or jQuery UI 1.7?

jQuery 1.7. Just checked; same behaviour with 1.8.2
1.10.2 for jQuery UI for both.

#13: I see that zurb_foundation overrides *a lot* of field output; it implements THEMENAME_field(), THEMENAME_field__taxonomy_term_reference() and THEMENAME_preprocess_field(). I'm certain that somewhere in there, things are being broken.
If the theme prevents the data- attribute set by edit_preprocess_field() from showing up, then *that* is the cause.

Please open an issue in their issue queue with this information.

Once they've fixed it, I'll add the above information (along with extra information likely, that we'll figure out as we go along with getting zurb_foundation to support Edit) to the README to clearly document it for other themes.

This is now blocked on feedback from the Zurb folks.

Thanks for the additional info Wim.

We found out that in for example the Omega theme the BEM syntax (naming convention) screws up the inline editing.
Could you have a look here again?
My question is: does edit need to be less strict or Omega altered?

Replied there.

So, my theme isn't based on Zurb (it's boostrap). Disabling all my theme overrides and js (including Boostrap's), it doesn't fix this problem -- when I look at the source, the field-items are correctly wrapped with the edit classes and urls. Any thoughts?

ETA: Ah. Went back to jQuery 1.5 and it works. So definitely a js compatibility issue. Are there any plans to make it work with 1.7/1.8? Most people who use jQuery update will be able to run that on their front-ends now while using 1.5 on the backend only, which means more theme incompatibility threads like this on the horizon...

Edit does work with jQuery 1.7/1.8. It does not work with jQuery UI 1.10. I suspect that's the problem.

Hmm, ok, thanks. As there's no nice way to uncouple the UI version from the jQuery version, my previous comment re: this becoming a commonly-seen config still stands. It would be great to get UI 1.10 support on the roadmap :)

#19: there's a patch for that: #1962274-3: jQuery UI 1.10 compatibility. The reason it isn't committed yet is because jQuery UI 1.10 compatibility breaks jQuery UI <=1.10 compatibility… :)

Referencing #1986340: Incompatible with Bootstrap theme

With #2167981: Do a best-effort theme compatibility check in the status report in, I consider this issue fully addressed now. In case we encounter more problems with themes, I'll continue to add more advanced checks to the Status Report for Edit.