Closed (fixed)
Project:
Internationalization
Version:
7.x-1.x-dev
Component:
Strings
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Apr 2013 at 19:52 UTC
Updated:
10 Feb 2014 at 08:30 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
benjifisherThe attached patch adds a test for
is_array($string). I also made a similar change instring_filter()later on. This may not be needed, but it should not cause any problems, either.Comment #1.0
benjifisherShow the screen shot in-line.
Comment #2
benjifisherSetting the status to NR.
Comment #3
benjifisherCleaning up the description. How did that get in there?
Comment #4
jose reyero commentedRight about the issue in the first function, though it can be fixed just by some reordering, see attached patch.
About the second one, the parameter *must* be an array, so if it is not, the bug is somewhere else.
Comment #5
guillaumeduveauPatch in #4 applies and seems OK to me.
Comment #6
jose reyero commentedGreat, thanks for the review.
Committed the patch #4 with some api documentation updates for the string_filter() method.
Thanks.