This module adds Gauges analytics tracking to a website in a similar fashion to the existing Google Analytics module. It adheres to the recommendations of Gauges and follows the Drupal coding standards and best practices.

Current Sandbox

Gauges Sandbox

Git repository cloning

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/grantlucas/1963346.git gauges

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxgrantlucas1963346git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

markpavlitski’s picture

markpavlitski commented

There are a few comment and spelling issues, please have a look at the comment guidelines here:

http://drupal.org/coding-standards/docs#general

grantlucas’s picture

grantlucas commented
Status: Needs work » Needs review

Thanks for taking a look. I've gone through and corrected comments to have full stops and ensured that variables through variable_get/set() are prefixed with "gauges".

markpavlitski’s picture

markpavlitski commented
Status: Needs review » Needs work

@grantlucas, I see you've renamed 'gauge_id' to 'gauges_gauge_id', but there are still a few references to the old variable.

At the moment the admin page doesn't appear to save the ID, because the old format is used on the form. See gauges.module: lines 56 and 110.

It might also be worth adding a
hook_update_N() function to convert the old variables to the new format, so that your settings aren't lost. What do you think?

Edit: I would also suggest using form_set_value() in gauges_settings_form_validate() rather than setting the value directly.

grantlucas’s picture

grantlucas commented
Status: Needs work » Needs review

Ah good catch. I've updated and tested that the saving works. I also added an install file with hook_update_N to migrate to the new name to preserve existing settings.

Good thinking on the settings migration in the update function. :)

Also ran it through validation etc to ensure comments and coding is up to standards still.

markpavlitski’s picture

markpavlitski commented

You might want to delete the old variable in your hook_update_N() as well, but otherwise all looks good!

Edit: you should add a hook_uninstall() to delete your new variables too!

markpavlitski’s picture

markpavlitski commented

Just a thought, is there a particular format that the gauge ID's use? It might be worth validating that the user has entered the ID in the correct format?

grantlucas’s picture

grantlucas commented

Thanks for the additional feedback. I've added hook_uninstall to remove gauges_* variables. I've opted not to delete the old gauge_id variable on the remote, off chance that that is being used by something else already. Figured it would be best to play it safe.

For the Gauge ID, there's no format that I've been able to discern and gaug.es doesn't provide any documentation on how it's generated so I don't think any validation can be done at this point.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Reviewed & tested by the community

I'm not that sure what Guages is, but the code looks fine.

----
Top Shelf Modules - Enterprise modules from the community for the community.

grantlucas’s picture

grantlucas commented

Thanks for the review! Gauges is an analytics setup similar to Google analytics...but different.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Needs work
Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

----
Top Shelf Modules - Crafted, Curated, Contributed.

grantlucas’s picture

grantlucas commented
Status: Needs work » Reviewed & tested by the community

Hi there. Thanks for taking a look at this module.

All work is being done in the primary 7.x-1.x branch. There's a residual master branch on origin from initial creation but I'm unable to delete it. All other work so far has been under 7.x-1.x to adhere to Drupal standards.

Doing git push origin :master results in an error that the master branch can't be deleted etc.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the updated info.

Thanks for your contribution, grantlucas!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

grantlucas’s picture

grantlucas commented

Thank you for the promotion!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.