search_tweets method not working in Twitter API library [#1963524]

Comment	File	Size	Author
#12	twitter_1963524_12.patch	1.52 KB	xano
#8	fix_search_tweets-1963524-8.patch	1.46 KB	sheldon rampton
#6	fix_search_tweets-1963524-6.patch	1.46 KB	sheldon rampton
#4	fix_search_tweets-1963524-4.patch	1.26 KB	sheldon rampton
#1	fix_search_tweets-1963524-1.patch	1.25 KB	sheldon rampton

Comment #1

sheldon rampton commented 7 April 2013 at 07:27

Status:

Active

» Needs review

Status	File	Size
new	fix_search_tweets-1963524-1.patch	1.25 KB

Here's a patch that fixes this issue.

Log in or register to post comments

Comment #2

lukus

he/him

commented 16 April 2013 at 22:39

Works well for me. Thanks very much :)

Log in or register to post comments

Comment #3

juampynr commented 25 April 2013 at 14:40

Version:	7.x-5.x-dev	» 7.x-6.x-dev
Status:	Needs review	» Needs work

Please re-roll for 7.x-6.x.

Log in or register to post comments

Status	File	Size
new	fix_search_tweets-1963524-4.patch	1.26 KB

@juampy, in the future, I'll plan on creating a 7.x-6.x version for any patches that I submit, which can then be backported as needed to 7.x-5.x and 6.x-5.x. However, I may first post a patch that corresponds to the module version where I first encounter a need to patch something.

Log in or register to post comments

Comment #5

juampynr commented 26 April 2013 at 07:01

Status:

Needs review

» Needs work

Here are some comments from my review.

+++ b/twitter.lib.phpundefined
@@ -219,6 +219,27 @@ class Twitter {
   /**
+   * Get an array of TwitterStatus objects from an API endpoint

Please add docblocks as per Doxygen coding standards (http://drupal.org/node/1354). You can see examples in other functions of this file.

+++ b/twitter.lib.phpundefined
@@ -219,6 +219,27 @@ class Twitter {
+    if ($values && $values['statuses']) {

wrap array index checks with isset() to avoid warnings.

+++ b/twitter.lib.phpundefined
@@ -431,7 +452,7 @@ class Twitter {
+    return $this->get_search_results('search/tweets', $params);

If search is just to be done on search/tweets path within the Twitter API, we could remove this attribute and just use this path within get_search_results(), don't you think so?

Log in or register to post comments

Comment #6

sheldon rampton commented 26 April 2013 at 08:24

Status:

Needs work

» Needs review

Status	File	Size
new	fix_search_tweets-1963524-6.patch	1.46 KB

OK, here's an updated patch.

Log in or register to post comments

Comment #7

juampynr commented 29 April 2013 at 13:20

Status:

Needs review

» Fixed

Committed. Thanks!

Just fixed a typo with the return array of get_search_resuls().

http://drupalcode.org/project/twitter.git/commit/718fd61

Feel free to reopen with a patch for 7.x-5.x.

Log in or register to post comments

Comment #8

sheldon rampton commented 30 April 2013 at 19:03

Version:	7.x-6.x-dev	» 7.x-5.x-dev
Status:	Fixed	» Needs review

Status	File	Size
new	fix_search_tweets-1963524-8.patch	1.46 KB

OK, here's a backport of the patch for 7.x-5.x.

Log in or register to post comments

Comment #9

sheldon rampton commented 25 June 2013 at 15:23

@juampy: Can you review and apply this patch? It's a straightforward backport of the version for 7.x-6.x, and it fixes a bug that I need fixed for my twitter_search module to work properly.

Log in or register to post comments

Comment #10

sheldon rampton commented 15 July 2013 at 03:58

Status:

Needs review

» Reviewed & tested by the community

@juampy: Can you please take a look at this patch and commit it? I submitted it back in April, and I think it's very straightforward, so it should be easy for you to review and act on it.