Caption Filter's CSS was originally written before the responsive design really took hold. Unfortunately, some of this module's CSS hasn't held up very well. A clean-up and optimization pass would be useful.

CommentFileSizeAuthor
#1 caption-filter-responsiveness-1963526-1.patch1.29 KBkmonty

Comments

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented
Status: Active » Needs review
StatusFileSize
new caption-filter-responsiveness-1963526-1.patch1.29 KB

Patch below. I'd like a couple eyes on this before committing it to the project, as it changes the output markup and slightly adjusting the CSS, which could cause unexpected results on existing sites.

populist’s picture

populist commented

I think these are pretty reasonable changes which seem mostly designed at not having the markup break when an image is placed inside larger than the container's width. I wouldn't go beyond this with responsive support (since that probably should be left up to the img element itself) but seems good.

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented

Yes, I resisted making left/right aligned images responsive because it's ultimately up to the site themer for how that should be handled.

(On my personal site, I generally only left/right align thumbnail images. I have responsive media queries to resize those images/containing divs as appropriate until a (max-width: 500px) breakpoint (all cellphones, regardless of orientation), at which point the "thumbnail" is allowed to be 100% of the width of the containing div.)

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.