A new install off of dev branch will always report it has failed.
This is because forward.install used to store the CREATE TABLE query results in $query, and then check for $query's existence to see if the installation succeeded. When forward_statistics was added, the '$query = db_query(...' line was changed to simply 'db_query(...', but the check to see if $query existed was left in.
Patch for forward.install enclosed. I really don't know that the check is actually necessary, as IIRC if the table insert fails Drupal will throw a logged warning anyway so this just seems to duplicate functionality. But just to leave the code closer to how it originally worked, I left the check in. It can trivially be removed later if that's deemed appropriate.
| Comment | File | Size | Author |
|---|---|---|---|
| forward.install.HEAD_.r0.patch | 1.83 KB | gnassar |
Comments
Comment #1
seanrFixed, thanks for catching that.
Comment #2
suzanne.aldrich commentedHi, I tried forward-5.x-1.x-dev (Dec. 1) and still got an error on install about needing to hand install the tables. However, it appears that the module installed just fine and works.
Comment #3
suzanne.aldrich commentedActually, I think my install did partly fail: see http://drupal.org/node/197162
Comment #4
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.