[D7] Comment Sources

I really like the sound of this module - it would be very useful to be able to integrate multiple comment sources, rather than having to choose which one to use.

Automated check:

See http://ventral.org/pareview/httpgitdrupalorgsandboxbaisong1968806git

There are quite a few things here that are simply code styling, but tidying them up is necessary and also makes a manual code review much easier.

Manual review:

The git source has two branches at the moment: named master, and 7.x-1.0-beta.

The master branch should be removed (to do this, "Edit" the project, and change the default branch to be the 7.x 1; you can then use branch -d to delete the branch, followed by push origin :master). The 7.x branch should be named 7.x-1.x; the 7.x-1.0 comes in when you name it that for a full release, or 7.x-1.0-beta1 if you want it to be a beta release. Branches are not named in this way, but are simply named after the Drupal version they work with (7.x-) and the major version number this is (-1.x).

I notice that the function comment_sources_should_display_comments contains quite a bit of code that is a previous implementation, now commented out.

The readme file should be named README.txt not README.md, and should be more of a free-text explanation of the module.

That should give you a few things to work on for now. I'll end by reiterating what I said at the start, however: It'll be good to see this module when it's ready for the contrib repository.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

1. comments_sources.js:
Put code as following:
(function ($) {
// All your code here with $ instead of jQuery
})(jQuery);

http://drupal.org/node/756722

2. comments_sources.info
Consider to load file only when necessary.

Generally, nice coding.

We already have some modules for Disqus and Facebook Comments Social Plugin. Is there a way you could work with these modules instead of duplicating a lot of similar code?

----
Top Shelf Modules - Enterprise modules from the community for the community.

@kscheirer, this modules *integrates* with Disqus and FB social plugins. There is no code duplication.

Concur with @ferdi should be reviewed & tested. Module allows choice between multiple comment "modules" within the same Drupal install.

Sorry! Somehow I missed that. RTBC from me then as well.

There are still a fair amount of style errors reported here: http://ventral.org/pareview/httpgitdrupalorgsandboxbaisong1968806git. You should also add an INSTALL.txt file that explains how to make use of the patches provided and why they are necessary. Looks like a nice module though!

Thanks for your contribution, baisong!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.