cvs.css not included for project/cvs/* pages
Junyor - December 2, 2007 - 17:00
| Project: | CVS integration |
| Version: | 5.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
The CSS styling added in http://drupal.org/node/10928 and changed in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cvslog/cvs.... is no longer working: long entries in the Drupal.org CVS log don't wrap. Unfortunately, I don't have a setup for testing the CVS module, otherwise I'd try to fix this myself. The problem may be related to the use of drupal_set_html_head rather than drupal_add_css. I also don't know what version of the module is running on Drupal.org.
#1
For reference, I just tested it for Commit Log (based on Version Control API) and Garland, and long messages break properly there. I've got that code directly from cvs.module, so it can't be far away from working. Maybe bluebeach messes with this CSS somehow?
#2
It's possible. Can you check your page source code to make sure there's a style element there?
#3
I don't have a setup for testing CVSlog but was just looking at this issue on d.o.
The cvs messages on d.o are wrapping for me except for strings that are too long to wrap. The paths that are too long to wrap are overflowing under the right boxes.
http://drupal.org/node/10928 #2 suggests using "overflow: auto" to get a horizontal scrolling area if the information is too large to fit in the area of the page. Testing with Firebug this seems to work for the long paths and function names that lack the white space to wrap.
#4
The CSS to fix this is already in the CSS file for the cvslog module, it's just not being applied.
#5
duplicate of http://drupal.org/node/71359
#6
reopening, b/c http://drupal.org/node/71359 was fixed and we're still having this issue on d.o
#7
What specifically needs to be fixed in bluebeach?
#8
@drumm: Bluebeach isn't showing the STYLE element inserted by cvs.module. The latest cvs.module in CVS uses drupal_add_css, but according to hunmonk, that's also not working.
#9
@drumm: here's the cvs.css file:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cvslog/cvs....
this is installed on d.o, and all relevant caches were cleared, but the commit message descriptions still aren't wrapping. my local test on the garland theme showed this CSS file to create the desired effect there, so i'm imagining that something is being overridden by a bluebeach CSS setting.
#10
Can you guys try turning off CSS caching on d.o? It's currently got all of the css combined into one compressed file, and I'm wondering if that might be causing this as I've had issues with that on other sites.
#11
@seanr: i cleared the CSS cache after i deployed this patch, so the newly compressed files should contain the cvs.css stuff. i don't think turning off the caching is really an option here, except to test if that's what's causing the problem.
#12
Bump: I just marked #269542: CVS log messages don't wrap duplicated of this.
#13
Does this happen on the scratch and project test sites?
#14
Yes, happens on project.d.o, for example:
http://project.drupal.org/project/cvs/38878
Shrink the width of the screen and you'll see the commit messages overflow.
What's weird is that they properly wrap at http://project.drupal.org/cvs
Looking briefly at the cvslog.module code and project.inc, I now see that this is actually a bug in one of those modules (though I can't decide which one -- it's a bug that project.inc is invoking a cvs-specific hook in the first place). ;) On cvslog.module managed pages, cvs.css is added. When project.module generates the page and invokes a hook from cvslog.module, there's no cvs.css added. I tested locally on a garland site and I see the same behavior. So, this is definitely not a bluebeach bug. Sorry about that.
#15