Successfully upgraded to Drupal 5
mustafau - December 3, 2007 - 00:06
| Project: | Webcomic |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Vyoma |
| Status: | closed |
Description
I have successfully upgraded this modules HEAD version to Drupal 5.
- Disabled Views functionality for now.
- Removed form elements that conflict with Image module.
- Added case 'pgsql' to webcomic_install().
- Modified some theme functions so that they work on sites lying under some directory like drupal.org/mysite.
| Attachment | Size |
|---|---|
| webcomic.info_.tar_.gz | 238 bytes |
| webcomic-5.x-0.x-dev.install.patch | 2.97 KB |
| webcomic-5.x-0.x-dev.module.patch | 19.47 KB |
| webcomic_theme-5.x-0.x-dev.inc_.patch | 5.04 KB |
#1
mustafau, first of all - thanks for the timely update. I was about to start actual upgrading of this module after documenting it at GDO (http://groups.drupal.org/node/7450).
In terms of the Views or anything else, if you could roughly document it at the Wiki (http://groups.drupal.org/node/7450) - I would be glad to work on it.
Or let me know what I need work on. ;)
#2
@Vyoma,
We should inform Eaton about our work here.
In terms of views.module integration I really don't know anything for now. Maybe I should read their documentation.
I worked a little more on this patch. As a result here is the unified patch file. In addition to the list above;
#3
@mustafau, I will run some tests on that patch :), and try to contact Eaton.
We can wait for a week - if not I guess we need to raise a request at http://drupal.org/project/issues/webmasters for inclusion of the patches.
#4
mustafau, can you verify this patch.
When I tried to apply the patch after applying the earlier patches, the
patchgave me this:Reversed (or previously applied) patch detected! Assume -R?#5
This was a replacement for the first set of patches. You should undo those patches before applying this.
#6
Cool - it works.
Thanks for bearing with me.
This is the first time I am actually contributing something through issue tracker. ;)
#7
I will review the code for functionality, clarity, and any other security threats I know of and create a dev branch for 5 so that it can be tested by others.
#8
I have applied the patch and verified the functionality. The patch disables the views and for this reason, the strips are not visible as expected. But I will commit this to the CVS and provide a 5.x-1.x-dev release for others to test and contribute.
#9
Patch committed.
New branch released as 5.x-1.x-dev. See the release snapshot.