I have successfully upgraded this modules HEAD version to Drupal 5.

  1. Disabled Views functionality for now.
  2. Removed form elements that conflict with Image module.
  3. Added case 'pgsql' to webcomic_install().
  4. Modified some theme functions so that they work on sites lying under some directory like drupal.org/mysite.
CommentFileSizeAuthor
#2 webcomic-upgrade-to-5.x.patch45.63 KBmustafau
webcomic_theme-5.x-0.x-dev.inc_.patch5.04 KBmustafau
webcomic-5.x-0.x-dev.module.patch19.47 KBmustafau
webcomic-5.x-0.x-dev.install.patch2.97 KBmustafau
webcomic.info_.tar_.gz238 bytesmustafau

Comments

Vyoma’s picture

Vyoma commented

mustafau, first of all - thanks for the timely update. I was about to start actual upgrading of this module after documenting it at GDO (http://groups.drupal.org/node/7450).

In terms of the Views or anything else, if you could roughly document it at the Wiki (http://groups.drupal.org/node/7450) - I would be glad to work on it.

Or let me know what I need work on. ;)

mustafau’s picture

mustafau commented
StatusFileSize
new webcomic-upgrade-to-5.x.patch45.63 KB

@Vyoma,
We should inform Eaton about our work here.
In terms of views.module integration I really don't know anything for now. Maybe I should read their documentation.

I worked a little more on this patch. As a result here is the unified patch file. In addition to the list above;

  • Comply with Drupal coding standards.
  • Added webcomic.css stylesheet.
Vyoma’s picture

Vyoma commented

@mustafau, I will run some tests on that patch :), and try to contact Eaton.

We can wait for a week - if not I guess we need to raise a request at http://drupal.org/project/issues/webmasters for inclusion of the patches.

Vyoma’s picture

Vyoma commented

mustafau, can you verify this patch.

When I tried to apply the patch after applying the earlier patches, the patch gave me this:

Reversed (or previously applied) patch detected! Assume -R?

mustafau’s picture

mustafau commented

This was a replacement for the first set of patches. You should undo those patches before applying this.

Vyoma’s picture

Vyoma commented

Cool - it works.

Thanks for bearing with me.

This is the first time I am actually contributing something through issue tracker. ;)

Vyoma’s picture

Vyoma commented
Assigned: Unassigned » Vyoma

I will review the code for functionality, clarity, and any other security threats I know of and create a dev branch for 5 so that it can be tested by others.

Vyoma’s picture

Vyoma commented
Status: Needs review » Reviewed & tested by the community

I have applied the patch and verified the functionality. The patch disables the views and for this reason, the strips are not visible as expected. But I will commit this to the CVS and provide a 5.x-1.x-dev release for others to test and contribute.

Vyoma’s picture

Vyoma commented
Status: Reviewed & tested by the community » Closed (fixed)

Patch committed.

New branch released as 5.x-1.x-dev. See the release snapshot.